From: Paul Moore <paul@paul-moore.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Casey Schaufler <casey@schaufler-ca.com>,
audit@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Eric Paris <eparis@redhat.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH v2 1/1] audit: Mark audit_log_vformat() with __printf() attribute
Date: Thu, 20 Mar 2025 18:02:12 -0400 [thread overview]
Message-ID: <c7f860b806603cd8af7740c73db68197@paul-moore.com> (raw)
In-Reply-To: <20250313085343.241623-1-andriy.shevchenko@linux.intel.com>
On Mar 13, 2025 Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
>
> audit_log_vformat() is using printf() type of format, and GCC compiler
> (Debian 14.2.0-17) is not happy about this:
>
> kernel/audit.c:1978:9: error: function ‘audit_log_vformat’ might be a candidate for ‘gnu_printf’ format attribute [-Werror=suggest-attribute=format]
> kernel/audit.c:1987:17: error: function ‘audit_log_vformat’ might be a candidate for ‘gnu_printf’ format attribute [-Werror=suggest-attribute=format]
>
> Fix the compilation errors (`make W=1` when CONFIG_WERROR=y, which is default)
> by adding __printf() attribute.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> v2: added necessary technical information to the commit message (Paul)
>
> kernel/audit.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Merged into audit/dev-staging, this will move to audit/dev after the
upcoming merge window.
--
paul-moore.com
next prev parent reply other threads:[~2025-03-20 22:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-13 8:52 [PATCH v2 1/1] audit: Mark audit_log_vformat() with __printf() attribute Andy Shevchenko
2025-03-20 15:19 ` Andy Shevchenko
2025-03-20 22:02 ` Paul Moore [this message]
2025-04-11 18:03 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7f860b806603cd8af7740c73db68197@paul-moore.com \
--to=paul@paul-moore.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=audit@vger.kernel.org \
--cc=casey@schaufler-ca.com \
--cc=eparis@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox