Re: [PATCH v5 1/2] audit: add audit_log_packet_ip4 and audit_log_packet_ip6 helper functions

Florian Westphal
2025-11-10T12:43:58Z

Ricardo Robaina <rrobaina@redhat.com> wrote:
> > +int audit_log_nft_skb(struct audit_buffer *ab,
> > + struct sk_buff *skb, u8 nfproto)
> Thanks for reviewing this patch, Paul.
>
> It makes sense to me. I'll work on a newer version addressing your suggestions.

Nit, but as you need to resend anyway, can you also make this
'const struct sk_buff *' ?

Also, given this isn't nftables specific, I suggest
audit_log_nf_skb, audit_log_netfilter_skb or some such instead.

Thanks.