From: Jens Axboe <axboe@kernel.dk>
To: Mateusz Guzik <mjguzik@gmail.com>, brauner@kernel.org
Cc: viro@zeniv.linux.org.uk, jack@suse.cz,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
io-uring@vger.kernel.org, audit@vger.kernel.org
Subject: Re: [PATCH] fs: support filename refcount without atomics
Date: Fri, 7 Mar 2025 09:18:32 -0700 [thread overview]
Message-ID: <fa3bbf2c-8079-4bdf-b106-a0641069080b@kernel.dk> (raw)
In-Reply-To: <20250307161155.760949-1-mjguzik@gmail.com>
> +static inline void makeatomicname(struct filename *name)
> +{
> + VFS_BUG_ON(IS_ERR_OR_NULL(name));
> + /*
> + * The name can legitimately already be atomic if it was cached by audit.
> + * If switching the refcount to atomic, we need not to know we are the
> + * only non-atomic user.
> + */
> + VFS_BUG_ON(name->owner != current && !name->is_atomic);
> + /*
> + * Don't bother branching, this is a store to an already dirtied cacheline.
> + */
> + name->is_atomic = true;
> +}
Should this not depend on audit being enabled? io_uring without audit is
fine.
--
Jens Axboe
next prev parent reply other threads:[~2025-03-07 16:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-07 16:11 [PATCH] fs: support filename refcount without atomics Mateusz Guzik
2025-03-07 16:18 ` Jens Axboe [this message]
2025-03-07 16:25 ` Mateusz Guzik
2025-03-07 16:32 ` Jens Axboe
2025-03-07 16:35 ` Mateusz Guzik
2025-03-07 16:38 ` Jens Axboe
2025-03-07 16:39 ` Mateusz Guzik
2025-03-07 16:26 ` Matthew Wilcox
2025-03-07 16:32 ` Mateusz Guzik
2025-03-07 16:42 ` Al Viro
2025-03-07 16:44 ` Mateusz Guzik
2025-03-07 22:58 ` Mateusz Guzik
2025-03-08 13:35 ` kernel test robot
2025-03-08 13:46 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa3bbf2c-8079-4bdf-b106-a0641069080b@kernel.dk \
--to=axboe@kernel.dk \
--cc=audit@vger.kernel.org \
--cc=brauner@kernel.org \
--cc=io-uring@vger.kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjguzik@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox