From: Christian Brauner <brauner@kernel.org>
To: NeilBrown <neil@brown.name>
Cc: Christian Brauner <brauner@kernel.org>,
linux-fsdevel@vger.kernel.org, autofs@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>, Jan Kara <jack@suse.cz>,
Ian Kent <raven@themaw.net>
Subject: Re: [PATCH] VFS/autofs: try_lookup_one_len() does not need any locks
Date: Fri, 14 Mar 2025 11:45:51 +0100 [thread overview]
Message-ID: <20250314-parabel-anmeldung-db05fcf4d133@brauner> (raw)
In-Reply-To: <174190517441.9342.5956460781380903128@noble.neil.brown.name>
On Fri, 14 Mar 2025 09:32:54 +1100, NeilBrown wrote:
> try_lookup_one_len() is identical to lookup_one_unlocked() except that
> it doesn't include the call to lookup_slow(). The latter doesn't need
> the inode to be locked, so the former cannot either.
>
> So fix the documentation, remove the WARN_ON and fix the only caller to
> not take the lock.
>
> [...]
Ok, I merged this into the afs branch with a merge commit explaining why.
---
Applied to the vfs-6.15.shared.afs branch of the vfs/vfs.git tree.
Patches in the vfs-6.15.shared.afs branch should appear in linux-next soon.
Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.
It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.
Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs-6.15.shared.afs
[1/1] VFS/autofs: try_lookup_one_len() does not need any locks
https://git.kernel.org/vfs/vfs/c/be348aed9b44
prev parent reply other threads:[~2025-03-14 10:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-13 22:32 [PATCH] VFS/autofs: try_lookup_one_len() does not need any locks NeilBrown
2025-03-14 10:45 ` Christian Brauner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250314-parabel-anmeldung-db05fcf4d133@brauner \
--to=brauner@kernel.org \
--cc=autofs@vger.kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=neil@brown.name \
--cc=raven@themaw.net \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).