Re: [PATCH RESEND] autofs: replace manual symlink buffer allocation in autofs_dir_symlink

Christian Brauner
2026-03-18T09:56:38Z

On Wed, Mar 18, 2026 at 01:12:21AM +0100, Thorsten Blum wrote:
> The symlink name was previously duplicated using an explicit kmalloc()
> followed by strcpy(), which is deprecated [1]. Replace this open-coded
> string duplication with kstrdup(), which allocates and copies the
> symlink name with a single helper function.
>
> Remove the local variable 'size' and set 'i_size' directly using
> strlen(cp), which is equivalent to the previous value of 'size'.
>
> This simplifies the code, uses common string-handling helpers, and
> removes the deprecated use of strcpy().
>
> Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strcpy [1]
> Acked-by: Ian Kent <raven@themaw.net>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---

Ideally always Cc fsdevel. This way the tooling sees it right away.