* WARNING: at fs/dcache.c:1359 d_set_d_op [was: mmotm 2011-01-06-15-41 uploaded]
[not found] <201101070014.p070Egpo023959@imap1.linux-foundation.org>
@ 2011-01-13 9:52 ` Jiri Slaby
2011-01-13 9:57 ` Jiri Slaby
2011-01-13 15:33 ` Valdis.Kletnieks
0 siblings, 2 replies; 7+ messages in thread
From: Jiri Slaby @ 2011-01-13 9:52 UTC (permalink / raw)
To: linux-kernel
Cc: akpm, mm-commits, linux-fsdevel, H. Peter Anvin, autofs, npiggin
On 01/07/2011 12:41 AM, akpm@linux-foundation.org wrote:
> The mm-of-the-moment snapshot 2011-01-06-15-41 has been uploaded to
Hi, after some uptime and several suspend/resume cycles, I got:
WARNING: at fs/dcache.c:1359 d_set_d_op+0x82/0xb0()
Hardware name: To Be Filled By O.E.M.
Modules linked in: dvb_usb_af9015 tda18271 af9013 dvb_usb dvb_core
Pid: 3474, comm: automount Tainted: G W 2.6.37-mm1_64+ #1344
Call Trace:
[<ffffffff8106bd2a>] ? warn_slowpath_common+0x7a/0xb0
[<ffffffff8106bd75>] ? warn_slowpath_null+0x15/0x20
[<ffffffff81125a32>] ? d_set_d_op+0x82/0xb0
[<ffffffff8120d829>] ? autofs4_dir_mkdir+0x169/0x180
[<ffffffff8111caa8>] ? vfs_mkdir+0x78/0xa0
[<ffffffff811209e6>] ? sys_mkdirat+0xf6/0x110
[<ffffffff81120a13>] ? sys_mkdir+0x13/0x20
[<ffffffff81030dbb>] ? system_call_fastpath+0x16/0x1b
I changed those BUG_ONs to WARN_ONs intentionally because I had problems
with that previously -- I had to:
dentry->d_flags &= ~(DCACHE_OP_HASH | DCACHE_OP_COMPARE |
DCACHE_OP_REVALIDATE | DCACHE_OP_REVALIDATE_RCU |
DCACHE_OP_DELETE);
in d_set_d_op to not oops when calling NULLish op->d_delete later.
The "Tainted: G W" is caused by:
https://lkml.org/lkml/2011/1/10/63
regards,
--
js
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: WARNING: at fs/dcache.c:1359 d_set_d_op [was: mmotm 2011-01-06-15-41 uploaded]
2011-01-13 9:52 ` WARNING: at fs/dcache.c:1359 d_set_d_op [was: mmotm 2011-01-06-15-41 uploaded] Jiri Slaby
@ 2011-01-13 9:57 ` Jiri Slaby
2011-01-13 10:54 ` Nick Piggin
2011-01-13 15:33 ` Valdis.Kletnieks
1 sibling, 1 reply; 7+ messages in thread
From: Jiri Slaby @ 2011-01-13 9:57 UTC (permalink / raw)
To: linux-kernel
Cc: akpm, mm-commits, linux-fsdevel, H. Peter Anvin, autofs, npiggin
On 01/13/2011 10:52 AM, Jiri Slaby wrote:
> On 01/07/2011 12:41 AM, akpm@linux-foundation.org wrote:
>> The mm-of-the-moment snapshot 2011-01-06-15-41 has been uploaded to
>
> Hi, after some uptime and several suspend/resume cycles, I got:
> WARNING: at fs/dcache.c:1359 d_set_d_op+0x82/0xb0()
> Hardware name: To Be Filled By O.E.M.
> Modules linked in: dvb_usb_af9015 tda18271 af9013 dvb_usb dvb_core
> Pid: 3474, comm: automount Tainted: G W 2.6.37-mm1_64+ #1344
> Call Trace:
> [<ffffffff8106bd2a>] ? warn_slowpath_common+0x7a/0xb0
> [<ffffffff8106bd75>] ? warn_slowpath_null+0x15/0x20
> [<ffffffff81125a32>] ? d_set_d_op+0x82/0xb0
> [<ffffffff8120d829>] ? autofs4_dir_mkdir+0x169/0x180
> [<ffffffff8111caa8>] ? vfs_mkdir+0x78/0xa0
> [<ffffffff811209e6>] ? sys_mkdirat+0xf6/0x110
> [<ffffffff81120a13>] ? sys_mkdir+0x13/0x20
> [<ffffffff81030dbb>] ? system_call_fastpath+0x16/0x1b
Note that even the second WARN was trigerred too:
WARNING: at fs/dcache.c:1365 d_set_d_op+0x9e/0xb0()
Hardware name: To Be Filled By O.E.M.
flags=00004000
Modules linked in: dvb_usb_af9015 tda18271 af9013 dvb_usb dvb_core
Pid: 3474, comm: automount Tainted: G W 2.6.37-mm1_64+ #1344
Call Trace:
[<ffffffff8106bd2a>] ? warn_slowpath_common+0x7a/0xb0
[<ffffffff8106be01>] ? warn_slowpath_fmt+0x41/0x50
[<ffffffff81125a4e>] ? d_set_d_op+0x9e/0xb0
[<ffffffff8120d829>] ? autofs4_dir_mkdir+0x169/0x180
[<ffffffff8111caa8>] ? vfs_mkdir+0x78/0xa0
[<ffffffff811209e6>] ? sys_mkdirat+0xf6/0x110
[<ffffffff81120a13>] ? sys_mkdir+0x13/0x20
[<ffffffff81030dbb>] ? system_call_fastpath+0x16/0x1b
My d_set_d_op looks like:
WARN_ON(dentry->d_op);
if (WARN(dentry->d_flags & (DCACHE_OP_HASH |
DCACHE_OP_COMPARE |
DCACHE_OP_REVALIDATE |
DCACHE_OP_REVALIDATE_RCU|
DCACHE_OP_DELETE),
"flags=%.8x", dentry->d_flags)) {
dentry->d_flags &= ~(DCACHE_OP_HASH | DCACHE_OP_COMPARE |
DCACHE_OP_REVALIDATE | DCACHE_OP_REVALIDATE_RCU |
DCACHE_OP_DELETE);
}
So DCACHE_OP_REVALIDATE remained set.
> I changed those BUG_ONs to WARN_ONs intentionally because I had problems
> with that previously -- I had to:
> dentry->d_flags &= ~(DCACHE_OP_HASH | DCACHE_OP_COMPARE |
> DCACHE_OP_REVALIDATE | DCACHE_OP_REVALIDATE_RCU |
> DCACHE_OP_DELETE);
>
> in d_set_d_op to not oops when calling NULLish op->d_delete later.
>
>
> The "Tainted: G W" is caused by:
> https://lkml.org/lkml/2011/1/10/63
regards,
--
js
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: WARNING: at fs/dcache.c:1359 d_set_d_op [was: mmotm 2011-01-06-15-41 uploaded]
2011-01-13 9:57 ` Jiri Slaby
@ 2011-01-13 10:54 ` Nick Piggin
0 siblings, 0 replies; 7+ messages in thread
From: Nick Piggin @ 2011-01-13 10:54 UTC (permalink / raw)
To: Jiri Slaby
Cc: linux-kernel, akpm, mm-commits, linux-fsdevel, H. Peter Anvin,
autofs, npiggin
2011/1/13 Jiri Slaby <jirislaby@gmail.com>:
> On 01/13/2011 10:52 AM, Jiri Slaby wrote:
>> On 01/07/2011 12:41 AM, akpm@linux-foundation.org wrote:
>>> The mm-of-the-moment snapshot 2011-01-06-15-41 has been uploaded to
>>
>> Hi, after some uptime and several suspend/resume cycles, I got:
>> WARNING: at fs/dcache.c:1359 d_set_d_op+0x82/0xb0()
>> Hardware name: To Be Filled By O.E.M.
>> Modules linked in: dvb_usb_af9015 tda18271 af9013 dvb_usb dvb_core
>> Pid: 3474, comm: automount Tainted: G W 2.6.37-mm1_64+ #1344
>> Call Trace:
>> [<ffffffff8106bd2a>] ? warn_slowpath_common+0x7a/0xb0
>> [<ffffffff8106bd75>] ? warn_slowpath_null+0x15/0x20
>> [<ffffffff81125a32>] ? d_set_d_op+0x82/0xb0
>> [<ffffffff8120d829>] ? autofs4_dir_mkdir+0x169/0x180
>> [<ffffffff8111caa8>] ? vfs_mkdir+0x78/0xa0
>> [<ffffffff811209e6>] ? sys_mkdirat+0xf6/0x110
>> [<ffffffff81120a13>] ? sys_mkdir+0x13/0x20
>> [<ffffffff81030dbb>] ? system_call_fastpath+0x16/0x1b
>
> Note that even the second WARN was trigerred too:
> WARNING: at fs/dcache.c:1365 d_set_d_op+0x9e/0xb0()
> Hardware name: To Be Filled By O.E.M.
> flags=00004000
> Modules linked in: dvb_usb_af9015 tda18271 af9013 dvb_usb dvb_core
> Pid: 3474, comm: automount Tainted: G W 2.6.37-mm1_64+ #1344
> Call Trace:
> [<ffffffff8106bd2a>] ? warn_slowpath_common+0x7a/0xb0
> [<ffffffff8106be01>] ? warn_slowpath_fmt+0x41/0x50
> [<ffffffff81125a4e>] ? d_set_d_op+0x9e/0xb0
> [<ffffffff8120d829>] ? autofs4_dir_mkdir+0x169/0x180
> [<ffffffff8111caa8>] ? vfs_mkdir+0x78/0xa0
> [<ffffffff811209e6>] ? sys_mkdirat+0xf6/0x110
> [<ffffffff81120a13>] ? sys_mkdir+0x13/0x20
> [<ffffffff81030dbb>] ? system_call_fastpath+0x16/0x1b
>
> My d_set_d_op looks like:
> WARN_ON(dentry->d_op);
> if (WARN(dentry->d_flags & (DCACHE_OP_HASH |
> DCACHE_OP_COMPARE |
> DCACHE_OP_REVALIDATE |
> DCACHE_OP_REVALIDATE_RCU|
> DCACHE_OP_DELETE),
> "flags=%.8x", dentry->d_flags)) {
> dentry->d_flags &= ~(DCACHE_OP_HASH | DCACHE_OP_COMPARE |
> DCACHE_OP_REVALIDATE | DCACHE_OP_REVALIDATE_RCU |
> DCACHE_OP_DELETE);
> }
>
> So DCACHE_OP_REVALIDATE remained set.
>
>> I changed those BUG_ONs to WARN_ONs intentionally because I had problems
>> with that previously -- I had to:
>> dentry->d_flags &= ~(DCACHE_OP_HASH | DCACHE_OP_COMPARE |
>> DCACHE_OP_REVALIDATE | DCACHE_OP_REVALIDATE_RCU |
>> DCACHE_OP_DELETE);
>>
>> in d_set_d_op to not oops when calling NULLish op->d_delete later.
Thanks for reporting. I was a little over-optimistic in my assumption
that filesysystems
would be doing sane things with dentry->d_op.
Al has audited these guys and has a pull request pending.
In the meantime, avoiding the bug and flipping the bits off will work fine.
Thanks,
Nick
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: WARNING: at fs/dcache.c:1359 d_set_d_op [was: mmotm 2011-01-06-15-41 uploaded]
2011-01-13 9:52 ` WARNING: at fs/dcache.c:1359 d_set_d_op [was: mmotm 2011-01-06-15-41 uploaded] Jiri Slaby
2011-01-13 9:57 ` Jiri Slaby
@ 2011-01-13 15:33 ` Valdis.Kletnieks
2011-01-13 15:40 ` Jiri Slaby
1 sibling, 1 reply; 7+ messages in thread
From: Valdis.Kletnieks @ 2011-01-13 15:33 UTC (permalink / raw)
To: Jiri Slaby
Cc: linux-kernel, akpm, mm-commits, linux-fsdevel, H. Peter Anvin,
autofs, npiggin
[-- Attachment #1: Type: text/plain, Size: 848 bytes --]
On Thu, 13 Jan 2011 10:52:22 +0100, Jiri Slaby said:
> On 01/07/2011 12:41 AM, akpm@linux-foundation.org wrote:
> > The mm-of-the-moment snapshot 2011-01-06-15-41 has been uploaded to
>
> Hi, after some uptime and several suspend/resume cycles, I got:
> WARNING: at fs/dcache.c:1359 d_set_d_op+0x82/0xb0()
> Hardware name: To Be Filled By O.E.M.
> Modules linked in: dvb_usb_af9015 tda18271 af9013 dvb_usb dvb_core
> Pid: 3474, comm: automount Tainted: G W 2.6.37-mm1_64+ #1344
> Call Trace:
> [<ffffffff8106bd2a>] ? warn_slowpath_common+0x7a/0xb0
> [<ffffffff8106bd75>] ? warn_slowpath_null+0x15/0x20
> [<ffffffff81125a32>] ? d_set_d_op+0x82/0xb0
> [<ffffffff8120d829>] ? autofs4_dir_mkdir+0x169/0x180
Wow. So it wasn't just configfs that trips over this one. I'm now hoping that
Al audited all the pseudo file systems for this...
[-- Attachment #2: Type: application/pgp-signature, Size: 227 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: WARNING: at fs/dcache.c:1359 d_set_d_op [was: mmotm 2011-01-06-15-41 uploaded]
2011-01-13 15:33 ` Valdis.Kletnieks
@ 2011-01-13 15:40 ` Jiri Slaby
2011-01-14 8:20 ` [autofs] " Ian Kent
0 siblings, 1 reply; 7+ messages in thread
From: Jiri Slaby @ 2011-01-13 15:40 UTC (permalink / raw)
To: Valdis.Kletnieks
Cc: linux-kernel, akpm, mm-commits, linux-fsdevel, H. Peter Anvin,
autofs, npiggin, Al Viro
On 01/13/2011 04:33 PM, Valdis.Kletnieks@vt.edu wrote:
> On Thu, 13 Jan 2011 10:52:22 +0100, Jiri Slaby said:
>> On 01/07/2011 12:41 AM, akpm@linux-foundation.org wrote:
>>> The mm-of-the-moment snapshot 2011-01-06-15-41 has been uploaded to
>>
>> Hi, after some uptime and several suspend/resume cycles, I got:
>> WARNING: at fs/dcache.c:1359 d_set_d_op+0x82/0xb0()
>> Hardware name: To Be Filled By O.E.M.
>> Modules linked in: dvb_usb_af9015 tda18271 af9013 dvb_usb dvb_core
>> Pid: 3474, comm: automount Tainted: G W 2.6.37-mm1_64+ #1344
>> Call Trace:
>> [<ffffffff8106bd2a>] ? warn_slowpath_common+0x7a/0xb0
>> [<ffffffff8106bd75>] ? warn_slowpath_null+0x15/0x20
>> [<ffffffff81125a32>] ? d_set_d_op+0x82/0xb0
>> [<ffffffff8120d829>] ? autofs4_dir_mkdir+0x169/0x180
>
> Wow. So it wasn't just configfs that trips over this one. I'm now hoping that
> Al audited all the pseudo file systems for this...
Well, CCing Al.
I don't see any recent change in fs/autofs4 in:
http://git.kernel.org/?p=linux/kernel/git/viro/vfs-2.6.git;a=history;f=fs/autofs4;hb=refs/heads/for-next
So maybe not all?
regards,
--
js
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [autofs] WARNING: at fs/dcache.c:1359 d_set_d_op [was: mmotm 2011-01-06-15-41 uploaded]
2011-01-13 15:40 ` Jiri Slaby
@ 2011-01-14 8:20 ` Ian Kent
2011-01-16 11:32 ` Jiri Slaby
0 siblings, 1 reply; 7+ messages in thread
From: Ian Kent @ 2011-01-14 8:20 UTC (permalink / raw)
To: Jiri Slaby
Cc: Valdis.Kletnieks, autofs, mm-commits, npiggin, linux-kernel,
Al Viro, H. Peter Anvin, linux-fsdevel, akpm
On Thu, 2011-01-13 at 16:40 +0100, Jiri Slaby wrote:
> On 01/13/2011 04:33 PM, Valdis.Kletnieks@vt.edu wrote:
> > On Thu, 13 Jan 2011 10:52:22 +0100, Jiri Slaby said:
> >> On 01/07/2011 12:41 AM, akpm@linux-foundation.org wrote:
> >>> The mm-of-the-moment snapshot 2011-01-06-15-41 has been uploaded to
> >>
> >> Hi, after some uptime and several suspend/resume cycles, I got:
> >> WARNING: at fs/dcache.c:1359 d_set_d_op+0x82/0xb0()
> >> Hardware name: To Be Filled By O.E.M.
> >> Modules linked in: dvb_usb_af9015 tda18271 af9013 dvb_usb dvb_core
> >> Pid: 3474, comm: automount Tainted: G W 2.6.37-mm1_64+ #1344
> >> Call Trace:
> >> [<ffffffff8106bd2a>] ? warn_slowpath_common+0x7a/0xb0
> >> [<ffffffff8106bd75>] ? warn_slowpath_null+0x15/0x20
> >> [<ffffffff81125a32>] ? d_set_d_op+0x82/0xb0
> >> [<ffffffff8120d829>] ? autofs4_dir_mkdir+0x169/0x180
> >
> > Wow. So it wasn't just configfs that trips over this one. I'm now hoping that
> > Al audited all the pseudo file systems for this...
>
> Well, CCing Al.
>
> I don't see any recent change in fs/autofs4 in:
> http://git.kernel.org/?p=linux/kernel/git/viro/vfs-2.6.git;a=history;f=fs/autofs4;hb=refs/heads/for-next
>
> So maybe not all?
Did you see:
https://lkml.org/lkml/2011/1/12/394
Haven't had any feedback on this yet, odd or maybe no news is good news?
Ian
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [autofs] WARNING: at fs/dcache.c:1359 d_set_d_op [was: mmotm 2011-01-06-15-41 uploaded]
2011-01-14 8:20 ` [autofs] " Ian Kent
@ 2011-01-16 11:32 ` Jiri Slaby
0 siblings, 0 replies; 7+ messages in thread
From: Jiri Slaby @ 2011-01-16 11:32 UTC (permalink / raw)
To: Ian Kent
Cc: Valdis.Kletnieks, autofs, mm-commits, npiggin, linux-kernel,
Al Viro, H. Peter Anvin, linux-fsdevel, akpm
On 01/14/2011 09:20 AM, Ian Kent wrote:
> On Thu, 2011-01-13 at 16:40 +0100, Jiri Slaby wrote:
>> On 01/13/2011 04:33 PM, Valdis.Kletnieks@vt.edu wrote:
>>> On Thu, 13 Jan 2011 10:52:22 +0100, Jiri Slaby said:
>>>> On 01/07/2011 12:41 AM, akpm@linux-foundation.org wrote:
>>>>> The mm-of-the-moment snapshot 2011-01-06-15-41 has been uploaded to
>>>>
>>>> Hi, after some uptime and several suspend/resume cycles, I got:
>>>> WARNING: at fs/dcache.c:1359 d_set_d_op+0x82/0xb0()
>>>> Hardware name: To Be Filled By O.E.M.
>>>> Modules linked in: dvb_usb_af9015 tda18271 af9013 dvb_usb dvb_core
>>>> Pid: 3474, comm: automount Tainted: G W 2.6.37-mm1_64+ #1344
>>>> Call Trace:
>>>> [<ffffffff8106bd2a>] ? warn_slowpath_common+0x7a/0xb0
>>>> [<ffffffff8106bd75>] ? warn_slowpath_null+0x15/0x20
>>>> [<ffffffff81125a32>] ? d_set_d_op+0x82/0xb0
>>>> [<ffffffff8120d829>] ? autofs4_dir_mkdir+0x169/0x180
>>>
>>> Wow. So it wasn't just configfs that trips over this one. I'm now hoping that
>>> Al audited all the pseudo file systems for this...
>>
>> Well, CCing Al.
>>
>> I don't see any recent change in fs/autofs4 in:
>> http://git.kernel.org/?p=linux/kernel/git/viro/vfs-2.6.git;a=history;f=fs/autofs4;hb=refs/heads/for-next
>>
>> So maybe not all?
>
> Did you see:
> https://lkml.org/lkml/2011/1/12/394
I haven't.
> Haven't had any feedback on this yet, odd or maybe no news is good news?
Works for me.
thanks,
--
js
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2011-01-16 11:32 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <201101070014.p070Egpo023959@imap1.linux-foundation.org>
2011-01-13 9:52 ` WARNING: at fs/dcache.c:1359 d_set_d_op [was: mmotm 2011-01-06-15-41 uploaded] Jiri Slaby
2011-01-13 9:57 ` Jiri Slaby
2011-01-13 10:54 ` Nick Piggin
2011-01-13 15:33 ` Valdis.Kletnieks
2011-01-13 15:40 ` Jiri Slaby
2011-01-14 8:20 ` [autofs] " Ian Kent
2011-01-16 11:32 ` Jiri Slaby
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).