From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Layton Subject: Re: [PATCH 0/9] fs: add some missing ctime updates Date: Fri, 09 Jun 2023 09:27:36 -0400 Message-ID: <671ceeb2e019c11617a481739c2e17604456c48c.camel@kernel.org> References: <20230609125023.399942-1-jlayton@kernel.org> <2023060931-magazine-nickname-f386@gregkh> Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686317260; bh=oSuiJiclTzvMA00+ishDDZSJ5F4CCgIPlxz3qberOkU=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=ctTfeKacHWo5l9K9DxzQOrtlTLoG85/EKA7MvHQ/F1/2q0zByBrbmyXzsM5xu9ZiB z9wHdsdfD4pFeRxFcqVecbJ+Otm388ULgG+bsoled+ga5itRm8LLiC22OcTX19F+j+ 6yIPcNN1B7m9Ur7wYkJS4IGiKr+2aBq5+dqDL6XT4Raq7b5xw0RxxqP1BRnkC/teoQ 1BBAFxOID86v/atOu3NX+L9wnqyt+99xF7OTaMcfAz05y5B3IH3bJDB665QOEe/kU6 AzdHw7nXRvFkJ5TMlrv7YVHd1aILHvSrpMhR/sNk7+XbKVcwqz4pHqjL+n9s6tGy8X 915cASV+pKXDw== In-Reply-To: <2023060931-magazine-nickname-f386@gregkh> List-ID: Content-Type: text/plain; charset="us-ascii" To: Greg Kroah-Hartman Cc: Christian Brauner , Al Viro , Brad Warrum , Ritu Agarwal , Arnd Bergmann , Ian Kent , "Tigran A. Aivazian" , Jeremy Kerr , Ard Biesheuvel , Namjae Jeon , Sungjong Seo , Bob Peterson , Andreas Gruenbacher , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , John Johansen , Paul Moore , James Morris On Fri, 2023-06-09 at 15:10 +0200, Greg Kroah-Hartman wrote: > On Fri, Jun 09, 2023 at 08:50:14AM -0400, Jeff Layton wrote: > > While working on a patch series to change how we handle the ctime, I > > found a number of places that update the mtime without a corresponding > > ctime update. POSIX requires that when the mtime is updated that the > > ctime also be updated. > >=20 > > Note that these are largely untested other than for compilation, so > > please review carefully. These are a preliminary set for the upcoming > > rework of how we handle the ctime. > >=20 > > None of these seem to be very crucial, but it would be nice if > > various maintainers could pick these up for v6.5. Please let me know if > > you do. > >=20 > > Jeff Layton (9): > > ibmvmc: update ctime in conjunction with mtime on write > > usb: update the ctime as well when updating mtime after an ioctl > > autofs: set ctime as well when mtime changes on a dir > > bfs: update ctime in addition to mtime when adding entries > > efivarfs: update ctime when mtime changes on a write > > exfat: ensure that ctime is updated whenever the mtime is > > gfs2: update ctime when quota is updated > > apparmor: update ctime whenever the mtime changes on an inode > > cifs: update the ctime on a partial page write > >=20 > > drivers/misc/ibmvmc.c | 2 +- > > drivers/usb/core/devio.c | 16 ++++++++-------- > > fs/autofs/root.c | 6 +++--- > > fs/bfs/dir.c | 2 +- > > fs/efivarfs/file.c | 2 +- > > fs/exfat/namei.c | 8 ++++---- > > fs/gfs2/quota.c | 2 +- > > fs/smb/client/file.c | 2 +- > > security/apparmor/apparmorfs.c | 7 +++++-- > > security/apparmor/policy_unpack.c | 11 +++++++---- > > 10 files changed, 32 insertions(+), 26 deletions(-) > >=20 > > --=20 > > 2.40.1 > >=20 >=20 > All of these need commit log messages, didn't checkpatch warn you about > that? It did, once I ran it. ;) I'll repost the set with more elaborate changelogs. --=20 Jeff Layton