From mboxrd@z Thu Jan 1 00:00:00 1970 From: Miao Wang Date: Wed, 08 Jul 2026 05:16:26 +0800 Subject: [PATCH RFC v2 2/7] mfd: ls2kbmc: Sanity check for the connected pci port MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260708-ls2kbmc-mod-v2-2-2afdd1741766@gmail.com> References: <20260708-ls2kbmc-mod-v2-0-2afdd1741766@gmail.com> In-Reply-To: <20260708-ls2kbmc-mod-v2-0-2afdd1741766@gmail.com> To: Binbin Zhou , Chong Qiao , Lee Jones , Huacai Chen , Corey Minyard , Linus Walleij , Bartosz Golaszewski Cc: Xi Ruoyao , WANG Xuerui , Yinbo Zhu , Jiaxun Yang , mfd@lists.linux.dev, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, openipmi-developer@lists.sourceforge.net, Miao Wang X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2629; i=shankerwangmiao@gmail.com; s=20250715; h=from:subject:message-id; bh=No2dp/27RmGGcRyar1/5K91t4kgdhfDKTp+IZPk/ZDE=; b=owEBbQKS/ZANAwAKAbAx48p7/tluAcsmYgBqTWy17cBPz+Jt3b6qtwXjg5eSBXXWxqXQuY4LJ 6XYbBB2UtGJAjMEAAEKAB0WIQREqPWPgPJBxluezBOwMePKe/7ZbgUCak1stQAKCRCwMePKe/7Z brNZEACIOnwoJju5hxO6Gyd5YUIo7dsbTlH5rJx0U69xILYeuI5LRBpZhkFK76pRSe6/LmxXOJt 0Ymq/hrXkIJyJH9YcGIEE7H4IyIbjxvGosDeLtcuy5VEjr/ZESDJnVGgerauhu8U35amzB3Mpuc cRIJ5KkN5n2VsyC3NlfMzPMe2zDAX0u6PLQ6BxMx1bwa+KTG7lU8ZAD5QCr661fNUreQgMy8MF6 Pn02dQa1/AXUKxYOvxHMMZ6LJWe3GEFfu5GSdeYDFSGRcuqdfaIRkvUh2YJKSN0n5a3iV4rD4Gc crkPRchHEGpH8M1UeC2L6RoKw4pVk4lbvp3yhvHDN4hoKv0hhXgHbHVESpQ/MpM+Kr5yyoRfLwb OJbDwCzJX1s2H2OaP5lq/VRFunaZhaAaQU6S2j0apo7Bp2u/tckaZ8r24dWMOjQdayOwKpNIdOu RrdLVCw0+vYqOFxrr1W1Q2NI2zQ0N3ndA/IlcQuh+djPUrqVae9KLE4jJfwwn4VM1JcQ1ZuA1Rq XC/Verqd09bFAKjxT35enZ7mVh8AzmuFF2JcsB2xymH+PRLtbMYIaqD3ixYqX+YwGCD1L4pePT1 KqRkZTsFlMwXNOEAHDqHkaXVCpiMQ0LHXZu05z157uCfPn4aiEQN5fj5p85JV6wYZx4XTiyZEnM MnySiGC09JgU8Og== X-Developer-Key: i=shankerwangmiao@gmail.com; a=openpgp; fpr=6FAEFF06B7D212A774C60BFDFA0D166D6632EF4A X-Endpoint-Received: by B4 Relay for shankerwangmiao@gmail.com/20250715 with auth_id=462 List-Id: B4 Relay Submissions When the bmc resets, the recovery procedure require to reconfigure the parent device. The driver assumes that the parent device should be LS7A. Add a sanity check on initialization to ensure this and prevent from accidentally operating on non-LS7A ports. Fixes: d952bba3fbb5 ("mfd: ls2kbmc: Add Loongson-2K BMC reset function support") Signed-off-by: Miao Wang --- drivers/mfd/ls2k-bmc-core.c | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) diff --git a/drivers/mfd/ls2k-bmc-core.c b/drivers/mfd/ls2k-bmc-core.c index 27f6e096404d67459038a0607378057ec7ef69ab..b02e4955e9b04f517892a18b2ef103b5e481a238 100644 --- a/drivers/mfd/ls2k-bmc-core.c +++ b/drivers/mfd/ls2k-bmc-core.c @@ -35,6 +35,15 @@ #define LS2K_IPMI3_RES_START (LS2K_IPMI2_RES_START + LS2K_IPMI_RES_SIZE) #define LS2K_IPMI4_RES_START (LS2K_IPMI3_RES_START + LS2K_IPMI_RES_SIZE) +/* LS7A port Device IDs */ +#define DEV_LS7A1K_PCIE_PORT0 0x7a09 +#define DEV_LS7A1K_PCIE_PORT1 0x7a19 +#define DEV_LS7A1K_PCIE_PORT2 0x7a29 +#define DEV_LS7A2K_PCIE_PORT0 0x7a39 +#define DEV_LS7A2K_PCIE_PORT1 0x7a49 +#define DEV_LS7A2K_PCIE_PORT2 0x7a59 +#define DEV_LS7A2K_PCIE_PORT3 0x7a69 + #define LS7A_PCI_CFG_SIZE 0x100 /* LS7A bridge registers */ @@ -477,6 +486,24 @@ static int ls2k_bmc_parse_mode(struct pci_dev *pdev, struct simplefb_platform_da return -EINVAL; } +static const struct pci_device_id ls7a_ports[] = { + { PCI_DEVICE(PCI_VENDOR_ID_LOONGSON, DEV_LS7A1K_PCIE_PORT0) }, + { PCI_DEVICE(PCI_VENDOR_ID_LOONGSON, DEV_LS7A1K_PCIE_PORT1) }, + { PCI_DEVICE(PCI_VENDOR_ID_LOONGSON, DEV_LS7A1K_PCIE_PORT2) }, + { PCI_DEVICE(PCI_VENDOR_ID_LOONGSON, DEV_LS7A2K_PCIE_PORT0) }, + { PCI_DEVICE(PCI_VENDOR_ID_LOONGSON, DEV_LS7A2K_PCIE_PORT1) }, + { PCI_DEVICE(PCI_VENDOR_ID_LOONGSON, DEV_LS7A2K_PCIE_PORT2) }, + { PCI_DEVICE(PCI_VENDOR_ID_LOONGSON, DEV_LS7A2K_PCIE_PORT3) }, + { } +}; + +static bool ls2k_check_parent(struct pci_dev *dev) +{ + struct pci_dev *parent = dev->bus->self; + + return parent && pci_match_id(ls7a_ports, parent) != NULL; +} + static int ls2k_bmc_probe(struct pci_dev *dev, const struct pci_device_id *id) { struct simplefb_platform_data pd; @@ -488,6 +515,11 @@ static int ls2k_bmc_probe(struct pci_dev *dev, const struct pci_device_id *id) if (ret) return ret; + if (!ls2k_check_parent(dev)) { + dev_err(&dev->dev, "Expected to be connected to LS7A PCI-E port\n"); + return -ENODEV; + } + ddata = devm_kzalloc(&dev->dev, sizeof(*ddata), GFP_KERNEL); if (!ddata) return -ENOMEM; -- 2.49.0