From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michalis Niarchos Subject: [PATCH v3 0/3] perf tools: Fix memory issues Date: Mon, 03 Aug 2026 15:51:51 +0200 Message-Id: <20260803-perf-kvm-fixes-v3-0-e06268ec06fa@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAAAAAAAC/32Nyw6CMBBFf4V0bU0fKMWV/2FcDGUKVXmkxUZD+ Hdb2BgXLk/mnjMz8egsenLKZuIwWG+HPoLcZUS30DdIbR2ZCCaOrJCcjugMvYeOGvtCT4EXhgG wXEFNojQ6XA/RuVw39s/qhnpKlbRorZ8G914/Bp52W1wx+RsPnDIKh7pSeQm6LOS56cA+9nroS IoH8V8XUeeVlAVXpTFGf+vLsnwA1eAdUP0AAAA= X-Change-ID: 20260731-perf-kvm-fixes-a17f0aa048ad To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , James Clark Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Michalis Niarchos X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1785765118; l=2152; i=michael.niarchos@gmail.com; s=20260731; h=from:subject:message-id; bh=de1kxqA8d5DKcqsyDmns5DBbAlbhCSnEvCt61EciqhY=; b=783VwVM02QH6oEPgnq4OpaH7Ap2E9GdY7TNM0t624Qj1NtQdb2+KiuYnQKK9ccMUhON+euAvn qg9J0eRQ3OfB4inSRz9zumUImhSh7EyVd331E3hsoomdMh/6zA2jHTm X-Developer-Key: i=michael.niarchos@gmail.com; a=ed25519; pk=/LBZRQzfuxTnSaZhgZE8EP7mHr0poyqlKeFssNqkzFE= X-Endpoint-Received: by B4 Relay for michael.niarchos@gmail.com/20260731 with auth_id=912 List-Id: B4 Relay Submissions Running: $ perf kvm stat record -a sleep 10 gives this output: [ perf record: Woken up 1 times to write data ] [ perf record: Captured and wrote 1.361 MB perf.data.guest ] double free or corruption (!prev) In the process of resolving this, I came across some memory leaks. Signed-off-by: Michalis Niarchos --- Changes in v3: - Moved dead code removal to the correct patch. - Squashed double free patches, as both fix the same rec_argv double-free/leak pattern. - Link to v2: https://patch.msgid.link/20260803-perf-kvm-fixes-v2-0-1b337189fffc@gmail.com Changes in v2: - Removed code block that was rendered dead by the get_filename_for_perf_kvm() change. - Dropped invalid free() fix from kvm_events_report(). - Added double free fixes for: __cmd_record(), __cmd_report(), __cmd_buildid_list(), and __cmd_top(), which follow the same pattern as kvm_events_record(). - Link to v1: https://patch.msgid.link/20260803-perf-kvm-fixes-v1-0-a5db849ac973@gmail.com To: Peter Zijlstra To: Ingo Molnar To: Arnaldo Carvalho de Melo To: Namhyung Kim To: Mark Rutland To: Alexander Shishkin To: Jiri Olsa To: Ian Rogers To: Adrian Hunter To: James Clark Cc: linux-perf-users@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- Michalis Niarchos (3): perf tools: Fix memory leak in cmd_kvm() perf tools: Fix double free and memory leak issues perf tools: Fix memory leak in cmd_kvm() tools/perf/builtin-kvm.c | 99 +++++++++++------------- tools/perf/util/kvm-stat-arch/kvm-stat-powerpc.c | 4 +- tools/perf/util/kvm-stat-arch/kvm-stat-x86.c | 10 +-- 3 files changed, 50 insertions(+), 63 deletions(-) --- base-commit: a1ed064cb4db70af8c4177b3805ca5b8b0be567e change-id: 20260731-perf-kvm-fixes-a17f0aa048ad Best regards, -- Michalis Niarchos