From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maria Lisina Date: Sun, 13 Sep 2026 17:35:10 +0500 Subject: [PATCH] mfd/intel-lpss: Fix DebugFS initialization MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260913-intel-lpss-debugfs-v1-1-833cbb6fffc9@gmail.com> X-B4-Tracking: v=1; b=H4sIAH2YpmoC/x3MQQqAIBBA0avErBtQo6iuEi0qRxsIC6cikO6et HyL/xMIRSaBvkgQ6WbhPWTosoBlnYInZJsNRplGdbpCDidtuB0iaGm+vBMk56q6VVabroYcHpE cP/90GN/3A47qc8dkAAAA X-Change-ID: 20260913-intel-lpss-debugfs-eff3580d1295 To: Andy Shevchenko , Lee Jones Cc: mfd@lists.linux.dev, linux-kernel@vger.kernel.org, Maria Lisina X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2305; i=sekoohaka.sarisan@gmail.com; h=from:subject:message-id; bh=FnouczTsx4tPzXBDK+MbJJJlKWaBRjxUYVgKqRzth3E=; b=owEBbQKS/ZANAwAKARPrfuqZo5+iAcsmYgBqppiAr1TIjLCVF5PHCAA8MVyyIgwA54tG3Dtw/ fUvGEbjypCJAjMEAAEKAB0WIQQ8HZKKOdqg5DRiM0sT637qmaOfogUCaqaYgAAKCRAT637qmaOf oolBD/49Qua1T+BcMnmIDxFr8liPm9Sg9sz2rubCBcu3R9Y3yFfqo7xLmdkjwho6cEFtv2bvVnn HtoRqvsrJXpxc/1Wux/cJGqr9H0/fTl+HDP0ASyWF4hNvXk7mchGANyBNWsYb786Trt4DCfXC91 69biuX0MMWhHz87CU5plO4nEA05vFrChsnvpKp5y8NBYAuISIPUAtUi2JWYaWPfiQf2OljRaIHV BVbBf11I9dEgK2aURhAI40XEgdNNIxu7hA5YY8AFisgBtwYrtve5K2fkfJ7G/Mz2s78vaqqvVpT 9AIrujq5Z8ravjlCvPq7Ue+31GwANL7gzLW0UbiKVMlQW7vDd1mfsorOK5NZytJckT7XPf0C1S+ nsZoh/D2xZGosVqodn1uJABy0L9YQxQTJagPbqdyzLAOUGldWPVbVOiKXWO7KqMZSpHnnpTVrcC Q5bWrGsMgCFQ4c87F5zypl2mx8MXW9k8RHZMrJkUOMrpwWZjliuDVBSULlJ3f+DEHET62hMorl4 ganj7KD64C/JTV6fHLtVwlpa0mX1p6A1PUvlqP5xmeNz1eOQWdVHSQg2VQHEhJRxxTxoatgOjJ1 l2aiwp2Em80q1osKXja5MrTWGuOdIv0Rzqbxc0ikHAEwa3s/ZyMq9q+k+k1HhyS4ZlXIPnHxITP a7YtWazRvIRNIYA== X-Developer-Key: i=sekoohaka.sarisan@gmail.com; a=openpgp; fpr=3C1D928A39DAA0E43462334B13EB7EEA99A39FA2 X-Endpoint-Received: by B4 Relay for sekoohaka.sarisan@gmail.com/default with auth_id=1030 List-Id: B4 Relay Submissions The original code defers DebugFS check with unnecessary warning message which also appears when DebugFS is simply disabled. Therefore it spams dmesg with these messages: intel-lpss 0000:00:15.0: Failed to create debugfs entries intel-lpss 0000:00:15.3: Failed to create debugfs entries intel-lpss 0000:00:1e.0: Failed to create debugfs entries intel-lpss 0000:00:1e.2: Failed to create debugfs entries This patch adds proper checks to intel_lpss_exit() and intel_lpss_debugfs_add() functions and removes warning message. Signed-off-by: Maria Lisina --- drivers/mfd/intel-lpss.c | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/drivers/mfd/intel-lpss.c b/drivers/mfd/intel-lpss.c index 63d6694f71457b2e09d238af0a9bfb897a169a64..51550c1835c695b9081b33c67f81c19fee5e1652 100644 --- a/drivers/mfd/intel-lpss.c +++ b/drivers/mfd/intel-lpss.c @@ -146,9 +146,12 @@ static int intel_lpss_debugfs_add(struct intel_lpss *lpss) { struct dentry *dir; + if (!intel_lpss_debugfs) { + lpss->debugfs = NULL; + return 0; + } + dir = debugfs_create_dir(dev_name(lpss->dev), intel_lpss_debugfs); - if (IS_ERR(dir)) - return PTR_ERR(dir); /* Cache the values into lpss structure */ intel_lpss_cache_ltr(lpss); @@ -432,10 +435,7 @@ int intel_lpss_probe(struct device *dev, goto err_clk_register; intel_lpss_ltr_expose(lpss); - - ret = intel_lpss_debugfs_add(lpss); - if (ret) - dev_warn(dev, "Failed to create debugfs entries\n"); + intel_lpss_debugfs_add(lpss); if (intel_lpss_has_idma(lpss)) { ret = mfd_add_devices(dev, lpss->devid, &intel_lpss_idma64_cell, @@ -539,6 +539,13 @@ EXPORT_NS_GPL_DEV_PM_OPS(intel_lpss_pm_ops, INTEL_LPSS) = { static int __init intel_lpss_init(void) { intel_lpss_debugfs = debugfs_create_dir("intel_lpss", NULL); + + /* Ensure intel_lpss_debugfs stays NULL on error, + * so intel_lpss_debugfs_add exits properly. + */ + if (IS_ERR(intel_lpss_debugfs)) + intel_lpss_debugfs = NULL; + return 0; } module_init(intel_lpss_init); --- base-commit: 2f0c1cf72f4682178506f513bbf015e591b1aa4a change-id: 20260913-intel-lpss-debugfs-eff3580d1295 Best regards, -- Maria Lisina