From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 03969EB64DA for ; Wed, 14 Jun 2023 08:17:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2SEohH234H4GlWteq10J+nc7Bb7vwCMYNDA8KuZS7mg=; b=yiMISOoR6acsX4 GNhusRDOtRuJjuom2cSow04tCCwklg+vSeru/A053M/soXRnRMjhe4JWs6Ry4vA3ue02nGKKP/FoN NXu++Wun2RzqMav7hPneOATZ8tOTRa8cwGl1fP+xKrZfHe9wU6TeK+WFzBnYZGIb7R4r7vkOHYKgC pn1/uQo7TjD3QQPnp8IWiv8ZfNMaTMGzFu4HKMBzl/irNtJjHNXsECTOf8XA11KM+4crjQ9rbC83W 4Wg8YG16l5CgmWUa9S/AiBWOHRpvOLYijBEBEtU3rkKRy+b8q45FJ9eBNW7/AAna4UgCb5aZzxs8G enxMY149ixC4CJ1AbwHQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q9Lgo-00Ar5x-1F; Wed, 14 Jun 2023 08:17:14 +0000 Received: from s3.sipsolutions.net ([2a01:4f8:191:4433::2] helo=sipsolutions.net) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q9Lgk-00Ar5C-22 for b43-dev@lists.infradead.org; Wed, 14 Jun 2023 08:17:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=MIME-Version:Content-Transfer-Encoding: Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=hss47gyp6BYYMhFB7hAoae1QAy3auKS104enX9ZgrIY=; t=1686730630; x=1687940230; b=MX5Q1OKNaxE0pbxo5ugU8AJumLk781/uUL6I1kbJzJdPBDi jk12HTceTWGFIwu/CXwcmOY6wmZ9zz0rVXIpgUyN/svuQMlHtpcCl/+uRbfrueJg5xGjQT/RaX32k 4UhoIWHXVXGvInF5NRHgiK3Ys4IuKYQuczgGOpyc30nrDQ1vVT8ZfwkbvDA4jVCQ9FWgZH2l+haC2 er+4EjXg4XMPxwlMZGuLPM0asGs70+XuKnLEfujzVF6flZA/G2kQ58vLyN6rNJyzrQNY+OO1lCDjJ Pa1lHfGLEut5F+N8R0d92pp16rcZyvvHjbrPIg9QxjUwZs3UbeUa9ZXXrROBziyA==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.96) (envelope-from ) id 1q9LgY-0060G9-2h; Wed, 14 Jun 2023 10:16:59 +0200 Message-ID: <058dd31ef48495f8641f5b66839aaea039af0f08.camel@sipsolutions.net> Subject: Re: [PATCH] b43legacy: Remove unneeded variable From: Johannes Berg To: wuyonggang001@208suo.com, Larry.Finger@lwfinger.net, kvalo@kernel.org Cc: linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org, linux-kernel@vger.kernel.org Date: Wed, 14 Jun 2023 10:16:57 +0200 In-Reply-To: <12c1079d6e73f8f62c33b8a53dff7ff4de0728dc.camel@sipsolutions.net> References: <20230614075250.29097-1-zhanglibing@cdjrlc.com> <194e8e87fda5f02664fcfac3717458f2@208suo.com> <12c1079d6e73f8f62c33b8a53dff7ff4de0728dc.camel@sipsolutions.net> User-Agent: Evolution 3.48.3 (3.48.3-1.fc38) MIME-Version: 1.0 X-malware-bazaar: not-scanned X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230614_011710_692835_E55049F1 X-CRM114-Status: GOOD ( 10.21 ) X-BeenThere: b43-dev@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: b43/b43legacy Linux driver discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "b43-dev" Errors-To: b43-dev-bounces+b43-dev=archiver.kernel.org@lists.infradead.org On Wed, 2023-06-14 at 10:02 +0200, Johannes Berg wrote: > On Wed, 2023-06-14 at 15:55 +0800, wuyonggang001@208suo.com wrote: > > Fix the following coccicheck warning: > > > > drivers/net/wireless/broadcom/b43legacy/debugfs.c:68:9-14: Unneeded > > variable: "count". > > Hey, no. Please stop it already. This won't even _compile_. Just don't. > There's really not much value in cleaning up those coccicheck warnings > in the first place. You're just wasting everyone's time (including your > own). And BTW, I've just looked at all your other contributions to other areas of the kernel, and heard from others as well - not doing any better! I can only suggest that you stop all of your patch submissions and re- evaluate what you're even trying to do. And not just you personally, but all of the @208suo.com folks who popped up recently. johannes _______________________________________________ b43-dev mailing list b43-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/b43-dev