From: "Michael Büsch" <mb@bu3sch.de>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org
Subject: [PATCH] b43: remove extraneous code in free_ringmemory
Date: Mon, 25 Oct 2010 21:45:37 +0200 [thread overview]
Message-ID: <1288035937.24194.0.camel@maggie> (raw)
In-Reply-To: <1288016649-4334-1-git-send-email-linville@tuxdriver.com> (sfid-20101025_103012_756543_A179E9D6)
On Mon, 2010-10-25 at 10:24 -0400, John W. Linville wrote:
> This code seems to have been cut-n-pasted from alloc_ringmemory?
No. It's leftover from the old SSB DMA mem allocator, which needed
the GFP flags.
> Anyway, it is useless.
ACK.
> Signed-off-by: John W. Linville <linville@tuxdriver.com>
> ---
> drivers/net/wireless/b43/dma.c | 5 -----
> 1 files changed, 0 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/wireless/b43/dma.c b/drivers/net/wireless/b43/dma.c
> index 10d0aaf..3d5566e 100644
> --- a/drivers/net/wireless/b43/dma.c
> +++ b/drivers/net/wireless/b43/dma.c
> @@ -415,11 +415,6 @@ static int alloc_ringmemory(struct b43_dmaring *ring)
>
> static void free_ringmemory(struct b43_dmaring *ring)
> {
> - gfp_t flags = GFP_KERNEL;
> -
> - if (ring->type == B43_DMA_64BIT)
> - flags |= GFP_DMA;
> -
> dma_free_coherent(ring->dev->dev->dma_dev, B43_DMA_RINGMEMSIZE,
> ring->descbase, ring->dmabase);
> }
--
Greetings Michael.
prev parent reply other threads:[~2010-10-25 19:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-25 14:24 [PATCH] b43: remove extraneous code in free_ringmemory John W. Linville
2010-10-25 19:45 ` Michael Büsch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1288035937.24194.0.camel@maggie \
--to=mb@bu3sch.de \
--cc=b43-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox