* [PATCH] b43: remove extraneous code in free_ringmemory
@ 2010-10-25 14:24 John W. Linville
2010-10-25 19:45 ` Michael Büsch
0 siblings, 1 reply; 2+ messages in thread
From: John W. Linville @ 2010-10-25 14:24 UTC (permalink / raw)
To: linux-wireless; +Cc: b43-dev, John W. Linville
This code seems to have been cut-n-pasted from alloc_ringmemory?
Anyway, it is useless.
Signed-off-by: John W. Linville <linville@tuxdriver.com>
---
drivers/net/wireless/b43/dma.c | 5 -----
1 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/drivers/net/wireless/b43/dma.c b/drivers/net/wireless/b43/dma.c
index 10d0aaf..3d5566e 100644
--- a/drivers/net/wireless/b43/dma.c
+++ b/drivers/net/wireless/b43/dma.c
@@ -415,11 +415,6 @@ static int alloc_ringmemory(struct b43_dmaring *ring)
static void free_ringmemory(struct b43_dmaring *ring)
{
- gfp_t flags = GFP_KERNEL;
-
- if (ring->type == B43_DMA_64BIT)
- flags |= GFP_DMA;
-
dma_free_coherent(ring->dev->dev->dma_dev, B43_DMA_RINGMEMSIZE,
ring->descbase, ring->dmabase);
}
--
1.7.2.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* [PATCH] b43: remove extraneous code in free_ringmemory
2010-10-25 14:24 [PATCH] b43: remove extraneous code in free_ringmemory John W. Linville
@ 2010-10-25 19:45 ` Michael Büsch
0 siblings, 0 replies; 2+ messages in thread
From: Michael Büsch @ 2010-10-25 19:45 UTC (permalink / raw)
To: John W. Linville; +Cc: linux-wireless, b43-dev
On Mon, 2010-10-25 at 10:24 -0400, John W. Linville wrote:
> This code seems to have been cut-n-pasted from alloc_ringmemory?
No. It's leftover from the old SSB DMA mem allocator, which needed
the GFP flags.
> Anyway, it is useless.
ACK.
> Signed-off-by: John W. Linville <linville@tuxdriver.com>
> ---
> drivers/net/wireless/b43/dma.c | 5 -----
> 1 files changed, 0 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/wireless/b43/dma.c b/drivers/net/wireless/b43/dma.c
> index 10d0aaf..3d5566e 100644
> --- a/drivers/net/wireless/b43/dma.c
> +++ b/drivers/net/wireless/b43/dma.c
> @@ -415,11 +415,6 @@ static int alloc_ringmemory(struct b43_dmaring *ring)
>
> static void free_ringmemory(struct b43_dmaring *ring)
> {
> - gfp_t flags = GFP_KERNEL;
> -
> - if (ring->type == B43_DMA_64BIT)
> - flags |= GFP_DMA;
> -
> dma_free_coherent(ring->dev->dev->dma_dev, B43_DMA_RINGMEMSIZE,
> ring->descbase, ring->dmabase);
> }
--
Greetings Michael.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-10-25 19:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-25 14:24 [PATCH] b43: remove extraneous code in free_ringmemory John W. Linville
2010-10-25 19:45 ` Michael Büsch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).