From: "Rafał Miłecki" <zajec5@gmail.com>
To: linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
"Michael Büsch" <mb@bu3sch.de>
Cc: b43-dev@lists.infradead.org, "Rafał Miłecki" <zajec5@gmail.com>
Subject: [PATCH] ssb: fail registration for unknown SPROM revision
Date: Wed, 3 Nov 2010 23:28:46 +0100 [thread overview]
Message-ID: <1288823326-9686-2-git-send-email-zajec5@gmail.com> (raw)
In-Reply-To: <1288823326-9686-1-git-send-email-zajec5@gmail.com>
Signed-off-by: Rafa? Mi?ecki <zajec5@gmail.com>
---
As noticed my Michael we have this left from old times of limited amount of
revisions. It's not reliable to treat unknown as rev1.
Michael: would you like to add Reported-by?
John: it's for 2.6.38.
---
drivers/ssb/pci.c | 8 +++-----
1 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/ssb/pci.c b/drivers/ssb/pci.c
index b5343ac..41a7337 100644
--- a/drivers/ssb/pci.c
+++ b/drivers/ssb/pci.c
@@ -600,11 +600,9 @@ static int sprom_extract(struct ssb_bus *bus, struct ssb_sprom *out,
sprom_extract_r8(out, in);
break;
default:
- ssb_printk(KERN_WARNING PFX "Unsupported SPROM"
- " revision %d detected. Will extract"
- " v1\n", out->revision);
- out->revision = 1;
- sprom_extract_r123(out, in);
+ ssb_printk(KERN_ERR PFX "Unsupported SPROM revision %d"
+ " detected\n", out->revision);
+ return -EINVAL;
}
if (out->boardflags_lo == 0xFFFF)
--
1.6.0.4
next prev parent reply other threads:[~2010-11-03 22:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-03 22:28 [PATCH] ssb: return -ENOMEM on alloc fail (instead of CRC check's result) Rafał Miłecki
2010-11-03 22:28 ` Rafał Miłecki [this message]
2010-11-03 22:36 ` [PATCH] ssb: fail registration for unknown SPROM revision Michael Büsch
2010-11-16 21:23 ` John W. Linville
2010-11-17 17:12 ` Michael Büsch
[not found] ` <20101118162748.GB2468@tuxdriver.com>
2010-11-18 16:35 ` Michael Büsch
2010-11-18 16:44 ` Rafał Miłecki
2010-11-18 16:47 ` Michael Büsch
2010-11-18 17:02 ` Larry Finger
2010-11-18 17:07 ` Michael Büsch
2010-11-18 17:29 ` Larry Finger
[not found] ` <20101118162617.GA2468@tuxdriver.com>
2010-11-18 16:35 ` Rafał Miłecki
2010-11-03 22:31 ` [PATCH] ssb: return -ENOMEM on alloc fail (instead of CRC check's result) Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1288823326-9686-2-git-send-email-zajec5@gmail.com \
--to=zajec5@gmail.com \
--cc=b43-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mb@bu3sch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).