b43-dev.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: "Rafał Miłecki" <zajec5@gmail.com>
To: linux-wireless@vger.kernel.org,
	"John W. Linville" <linville@tuxdriver.com>
Cc: b43-dev@lists.infradead.org, "Rafał Miłecki" <zajec5@gmail.com>
Subject: [PATCH 1/4] b43: N-PHY: silence warnings
Date: Tue,  7 Dec 2010 21:55:57 +0100	[thread overview]
Message-ID: <1291755360-21570-2-git-send-email-zajec5@gmail.com> (raw)
In-Reply-To: <1291755360-21570-1-git-send-email-zajec5@gmail.com>

Signed-off-by: Rafa? Mi?ecki <zajec5@gmail.com>
---
 drivers/net/wireless/b43/phy_n.c |    8 ++++++--
 1 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/b43/phy_n.c b/drivers/net/wireless/b43/phy_n.c
index f78f4e9..d41da7f 100644
--- a/drivers/net/wireless/b43/phy_n.c
+++ b/drivers/net/wireless/b43/phy_n.c
@@ -258,7 +258,8 @@ static void b43_nphy_tx_power_fix(struct b43_wldev *dev)
 
 	for (i = 0; i < 2; i++) {
 		if (dev->phy.rev >= 3) {
-			/* TODO */
+			/* FIXME: support 5GHz */
+			txgain = b43_ntab_tx_gain_rev3plus_2ghz[txpi[i]];
 			radio_gain = (txgain >> 16) & 0x1FFFF;
 		} else {
 			txgain = b43_ntab_tx_gain_rev0_1_2[txpi[i]];
@@ -613,6 +614,8 @@ static void b43_nphy_rx_iq_coeffs(struct b43_wldev *dev, bool write,
 	}
 }
 
+#if 0
+/* Ready but not used anywhere */
 /* http://bcm-v4.sipsolutions.net/802.11/PHY/N/RxCalPhyCleanup */
 static void b43_nphy_rx_cal_phy_cleanup(struct b43_wldev *dev, u8 core)
 {
@@ -694,6 +697,7 @@ static void b43_nphy_rx_cal_phy_setup(struct b43_wldev *dev, u8 core)
 	b43_nphy_rf_control_intc_override(dev, 1, rxval, (core + 1));
 	b43_nphy_rf_control_intc_override(dev, 1, txval, (2 - core));
 }
+#endif
 
 /* http://bcm-v4.sipsolutions.net/802.11/PHY/N/CalcRxIqComp */
 static void b43_nphy_calc_rx_iq_comp(struct b43_wldev *dev, u8 mask)
@@ -3088,7 +3092,7 @@ static int b43_nphy_rev2_cal_rx_iq(struct b43_wldev *dev,
 	u8 rfctl[2];
 	u8 afectl_core;
 	u16 tmp[6];
-	u16 cur_hpf1, cur_hpf2, cur_lna;
+	u16 uninitialized_var(cur_hpf1), uninitialized_var(cur_hpf2), cur_lna;
 	u32 real, imag;
 	enum ieee80211_band band;
 
-- 
1.6.3.3

  reply	other threads:[~2010-12-07 20:55 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-07 20:55 [PATCH 0/4] Make N-PHY support experimental Rafał Miłecki
2010-12-07 20:55 ` Rafał Miłecki [this message]
2010-12-07 20:55 ` [PATCH 2/4] b43: set TMS to work with current band width for N-PHY Rafał Miłecki
2010-12-07 21:08   ` Michael Büsch
2010-12-09 14:12     ` Rafał Miłecki
2010-12-09 14:13       ` Rafał Miłecki
2010-12-09 14:19         ` Michael Büsch
2010-12-09 14:23           ` Rafał Miłecki
2010-12-09 14:28             ` Michael Büsch
2010-12-09 14:41             ` Michael Büsch
2010-12-07 20:55 ` [PATCH 3/4] b43: fix split of N-PHY devices into supported and not (based on PHY rev) Rafał Miłecki
2010-12-07 20:56 ` [PATCH 4/4] b43: rename config option for N-PHY, drop BROKEN Rafał Miłecki
2010-12-07 21:04 ` [PATCH 0/4] Make N-PHY support experimental Johannes Berg
2010-12-07 22:57 ` Gábor Stefanik
2010-12-07 23:11   ` Larry Finger
2010-12-08  3:37   ` Larry Finger
2010-12-09 14:11     ` Rafał Miłecki
2010-12-09 15:20       ` Larry Finger
2010-12-09 15:25         ` Johannes Berg
2010-12-09 15:28           ` Rafał Miłecki
2010-12-09 15:33             ` Johannes Berg
2010-12-09 15:37               ` Rafał Miłecki
2010-12-09 16:03                 ` Larry Finger
2010-12-10  3:52                   ` Jon Saul
2010-12-10  4:05                     ` Larry Finger
2010-12-09 16:10         ` Rafał Miłecki
2010-12-08 15:15   ` b43 N PHY status report Larry Finger
2010-12-10 16:57     ` Peter Stuge
2010-12-10 17:15       ` Larry Finger
2010-12-10 18:34         ` Peter Stuge
2010-12-10 18:44           ` Peter Stuge
2010-12-13 17:00             ` Rafał Miłecki
2010-12-13 17:41               ` Larry Finger
2010-12-13 18:17                 ` Rafał Miłecki
2010-12-13 18:37                   ` Larry Finger
2010-12-13 18:34                 ` Peter Stuge
2010-12-13 18:43                   ` Larry Finger
2010-12-10 18:22       ` Francesco Gringoli
2010-12-10 18:30     ` Francesco Gringoli
2010-12-10 18:47       ` Johannes Berg
2010-12-10 19:02         ` Larry Finger
2010-12-10 19:04           ` Gábor Stefanik
2010-12-10 19:08             ` Johannes Berg
2010-12-21  9:25               ` David Woodhouse
2010-12-21  9:30                 ` Rafał Miłecki
2010-12-21 14:30                 ` Larry Finger
2010-12-10 18:53     ` Konstantinos Karantias
2010-12-10 19:00       ` Larry Finger
2010-12-09 14:09   ` [PATCH 0/4] Make N-PHY support experimental Rafał Miłecki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1291755360-21570-2-git-send-email-zajec5@gmail.com \
    --to=zajec5@gmail.com \
    --cc=b43-dev@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).