From: "Michael Büsch" <mb@bu3sch.de>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
b43-dev@lists.infradead.org
Subject: [PATCH 2/4] b43: N-PHY: implement radio 2056 init steps
Date: Tue, 21 Dec 2010 12:34:33 +0100 [thread overview]
Message-ID: <1292931273.13493.2.camel@maggie> (raw)
In-Reply-To: <1292928622-27651-2-git-send-email-zajec5@gmail.com> (sfid-20101221_115045_163491_FFFFFFFFB31FEB6B)
On Tue, 2010-12-21 at 11:50 +0100, Rafa? Mi?ecki wrote:
> +static void b43_radio_init2056_post(struct b43_wldev *dev)
> +{
> + b43_radio_set(dev, B2056_SYN_COM_CTRL, 0xB);
> + b43_radio_set(dev, B2056_SYN_COM_PU, 0x2);
> + b43_radio_set(dev, B2056_SYN_COM_RESET, 0x2);
> + mdelay(1);
Please don't use mdelay() ever. The driver is fully preemptible.
Use msleep() instead.
--
Greetings Michael.
next prev parent reply other threads:[~2010-12-21 11:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-21 10:50 [PATCH 1/4] b43: use correct firmware for newer cores Rafał Miłecki
2010-12-21 10:50 ` [PATCH 2/4] b43: N-PHY: implement radio 2056 init steps Rafał Miłecki
2010-12-21 11:34 ` Michael Büsch [this message]
2010-12-21 12:20 ` Rafał Miłecki
2010-12-21 22:25 ` Michael Büsch
2010-12-21 22:33 ` Rafał Miłecki
2010-12-21 10:50 ` [PATCH 3/4] b43: N-PHY: add init tables for 2056 radio Rafał Miłecki
2010-12-21 10:50 ` [PATCH 4/4] b43: N-PHY: avoid PHY hangs for rev 3 and 4 Rafał Miłecki
[not found] ` <1292948026-472-1-git-send-email-zajec5@gmail.com>
2010-12-21 16:13 ` [PATCH 2/4 V2] b43: N-PHY: implement radio 2056 init steps Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1292931273.13493.2.camel@maggie \
--to=mb@bu3sch.de \
--cc=b43-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).