* ChipCommon as independent driver?
@ 2011-04-01 14:49 Rafał Miłecki
2011-04-01 16:00 ` Michael Büsch
0 siblings, 1 reply; 6+ messages in thread
From: Rafał Miłecki @ 2011-04-01 14:49 UTC (permalink / raw)
To: b43-dev, linux-wireless
I wanted to make ChipCommon independed, to make it usable with any
bus. The problem is:
void ssb_chipco_set_clockmode(struct ssb_chipcommon *cc, enum ssb_clkmode mode)
This function calls code from pci.c which gives us a loop:
WARNING: Module
/lib/modules/2.6.39-rc1-wl-wireless+/kernel/drivers/net/wireless/b43/b43.ko
ignored, due to loop
WARNING: Module
/lib/modules/2.6.39-rc1-wl-wireless+/kernel/drivers/ssb/ssb.ko
ignored, due to loop
WARNING: Loop detected:
/lib/modules/2.6.39-rc1-wl-wireless+/kernel/drivers/ssb/bcmcorecc.ko
needs ssb.ko which needs bcmcorecc.ko again!
WARNING: Module
/lib/modules/2.6.39-rc1-wl-wireless+/kernel/drivers/ssb/bcmcorecc.ko
ignored, due to loop
Do you have idea how we could nicely solve that issue?
--
Rafa?
^ permalink raw reply [flat|nested] 6+ messages in thread
* ChipCommon as independent driver?
2011-04-01 14:49 ChipCommon as independent driver? Rafał Miłecki
@ 2011-04-01 16:00 ` Michael Büsch
2011-04-01 16:06 ` Rafał Miłecki
0 siblings, 1 reply; 6+ messages in thread
From: Michael Büsch @ 2011-04-01 16:00 UTC (permalink / raw)
To: Rafał Miłecki; +Cc: b43-dev, linux-wireless
On Fri, 2011-04-01 at 16:49 +0200, Rafa? Mi?ecki wrote:
> Do you have idea how we could nicely solve that issue?
Yeah. Just don't share code between ssb and bcmai.
That's the only clean solution to that mess.
--
Greetings Michael.
^ permalink raw reply [flat|nested] 6+ messages in thread
* ChipCommon as independent driver?
2011-04-01 16:00 ` Michael Büsch
@ 2011-04-01 16:06 ` Rafał Miłecki
2011-04-01 16:15 ` Michael Büsch
0 siblings, 1 reply; 6+ messages in thread
From: Rafał Miłecki @ 2011-04-01 16:06 UTC (permalink / raw)
To: Michael Büsch; +Cc: b43-dev, linux-wireless
W dniu 1 kwietnia 2011 18:00 u?ytkownik Michael B?sch <mb@bu3sch.de> napisa?:
> On Fri, 2011-04-01 at 16:49 +0200, Rafa? Mi?ecki wrote:
>> Do you have idea how we could nicely solve that issue?
>
> Yeah. Just don't share code between ssb and bcmai.
> That's the only clean solution to that mess.
Do you want to have core drivers separated as well? Really? Should we
have separated pci core? chiccommon core? gige core? 80211 (b43) core?
My mistake was to include ssb_private.h in separated chipcommon.
--
Rafa?
^ permalink raw reply [flat|nested] 6+ messages in thread
* ChipCommon as independent driver?
2011-04-01 16:06 ` Rafał Miłecki
@ 2011-04-01 16:15 ` Michael Büsch
2011-04-01 16:21 ` Rafał Miłecki
0 siblings, 1 reply; 6+ messages in thread
From: Michael Büsch @ 2011-04-01 16:15 UTC (permalink / raw)
To: Rafał Miłecki; +Cc: linux-wireless, b43-dev
On Fri, 2011-04-01 at 18:06 +0200, Rafa? Mi?ecki wrote:
> W dniu 1 kwietnia 2011 18:00 u?ytkownik Michael B?sch <mb@bu3sch.de> napisa?:
> > On Fri, 2011-04-01 at 16:49 +0200, Rafa? Mi?ecki wrote:
> >> Do you have idea how we could nicely solve that issue?
> >
> > Yeah. Just don't share code between ssb and bcmai.
> > That's the only clean solution to that mess.
>
> Do you want to have core drivers separated as well? Really? Should we
> have separated pci core? chiccommon core?
Yes. Those "drivers" are a mess full of ssb specific workarounds
to hardware limitations.
> gige core?
Are there bcmai devices with gige core?
This driver is a _real_ mess. It basically is one huge
workaround, because the hardware is incredibly stupid.
> 80211 (b43) core?
No. The b43 (and b44) driver is pretty much self contained. It will be
easy
to make it run on both platforms. There are only a few places
that need changes.
--
Greetings Michael.
^ permalink raw reply [flat|nested] 6+ messages in thread
* ChipCommon as independent driver?
2011-04-01 16:15 ` Michael Büsch
@ 2011-04-01 16:21 ` Rafał Miłecki
2011-04-01 16:30 ` Michael Büsch
0 siblings, 1 reply; 6+ messages in thread
From: Rafał Miłecki @ 2011-04-01 16:21 UTC (permalink / raw)
To: Michael Büsch; +Cc: linux-wireless, b43-dev
W dniu 1 kwietnia 2011 18:15 u?ytkownik Michael B?sch <mb@bu3sch.de> napisa?:
> On Fri, 2011-04-01 at 18:06 +0200, Rafa? Mi?ecki wrote:
>> W dniu 1 kwietnia 2011 18:00 u?ytkownik Michael B?sch <mb@bu3sch.de> napisa?:
>> > On Fri, 2011-04-01 at 16:49 +0200, Rafa? Mi?ecki wrote:
>> >> Do you have idea how we could nicely solve that issue?
>> >
>> > Yeah. Just don't share code between ssb and bcmai.
>> > That's the only clean solution to that mess.
>>
>> Do you want to have core drivers separated as well? Really? Should we
>> have separated pci core? chiccommon core?
>
> Yes. Those "drivers" are a mess full of ssb specific workarounds
> to hardware limitations.
I really don't understand what you meant in:
2011/2/18 Michael B?sch <mb@bu3sch.de>:
> Note that this does not mean that we need to duplicate the MIPS,
> common and probably pci core drivers. A hybrid module can be done,
> if that's desired to avoid code duplication.
then :|
--
Rafa?
^ permalink raw reply [flat|nested] 6+ messages in thread
* ChipCommon as independent driver?
2011-04-01 16:21 ` Rafał Miłecki
@ 2011-04-01 16:30 ` Michael Büsch
0 siblings, 0 replies; 6+ messages in thread
From: Michael Büsch @ 2011-04-01 16:30 UTC (permalink / raw)
To: Rafał Miłecki; +Cc: linux-wireless, b43-dev
On Fri, 2011-04-01 at 18:21 +0200, Rafa? Mi?ecki wrote:
> W dniu 1 kwietnia 2011 18:15 u?ytkownik Michael B?sch <mb@bu3sch.de> napisa?:
> > On Fri, 2011-04-01 at 18:06 +0200, Rafa? Mi?ecki wrote:
> >> W dniu 1 kwietnia 2011 18:00 u?ytkownik Michael B?sch <mb@bu3sch.de> napisa?:
> >> > On Fri, 2011-04-01 at 16:49 +0200, Rafa? Mi?ecki wrote:
> >> >> Do you have idea how we could nicely solve that issue?
> >> >
> >> > Yeah. Just don't share code between ssb and bcmai.
> >> > That's the only clean solution to that mess.
> >>
> >> Do you want to have core drivers separated as well? Really? Should we
> >> have separated pci core? chiccommon core?
> >
> > Yes. Those "drivers" are a mess full of ssb specific workarounds
> > to hardware limitations.
>
> I really don't understand what you meant in:
>
> 2011/2/18 Michael B?sch <mb@bu3sch.de>:
> > Note that this does not mean that we need to duplicate the MIPS,
> > common and probably pci core drivers. A hybrid module can be done,
> > if that's desired to avoid code duplication.
>
> then :|
_can_ be done.
That doesn't mean it must be done or whether it's a good idea to do so.
It certainly is possible to do so, but I don't think it makes
a lot of sense.
--
Greetings Michael.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-04-01 16:30 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-01 14:49 ChipCommon as independent driver? Rafał Miłecki
2011-04-01 16:00 ` Michael Büsch
2011-04-01 16:06 ` Rafał Miłecki
2011-04-01 16:15 ` Michael Büsch
2011-04-01 16:21 ` Rafał Miłecki
2011-04-01 16:30 ` Michael Büsch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).