From: "Michael Büsch" <mb@bu3sch.de>
To: b43-dev@lists.infradead.org
Subject: Wrong offset for SSB_SPROM4_ANTAVAIL?
Date: Sat, 09 Apr 2011 13:31:30 +0200 [thread overview]
Message-ID: <1302348690.32142.0.camel@maggie> (raw)
In-Reply-To: <BANLkTinWc6egggjnY=FAB2fZsV7aOTusBQ@mail.gmail.com> (sfid-20110409_041102_586952_85A12BA9)
On Sat, 2011-04-09 at 10:10 +0200, Rafa? Mi?ecki wrote:
> 2011/4/9 Jonas Gorski <jonas.gorski@gmail.com>:
> > while matching SPROM content to its offsets, I noticed that
> > SSB_SPROM4_ANTAVAIL has an odd offset (0x5d)[1]. Shouldn't this be
> > rather even (probably 0x5c), since the SPROM consists of 16 bit words?
> >
> > Regards
> > Jonas
> >
> > [1] <http://git.kernel.org/?p=linux/kernel/git/linville/wireless-next-2.6.git;a=blob;f=include/linux/ssb/ssb_regs.h;h=402955ae48ceac9c118833bed28ca093407e4638;hb=HEAD#l290>
> >
> > P.S: I currently lack the free space for yet another kernel git tree,
> > so I would prefer if somebody else fixes this - assuming my analysis
> > is right ;-)
>
> I'll have time after weekend. There is some mess generally. We have
> ETHPHY instead of some LEDS and we have MASKs inverted for ANTENNA.
Note that the specs might also be incorrect on some of the fields.
There were bugfixes in the struct that were probably not propagated
up to the specs.
--
Greetings Michael.
next prev parent reply other threads:[~2011-04-09 11:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-08 23:28 Wrong offset for SSB_SPROM4_ANTAVAIL? Jonas Gorski
2011-04-09 8:10 ` Rafał Miłecki
2011-04-09 11:31 ` Michael Büsch [this message]
2011-04-09 22:11 ` Rafał Miłecki
2011-04-09 22:14 ` Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1302348690.32142.0.camel@maggie \
--to=mb@bu3sch.de \
--cc=b43-dev@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox