public inbox for b43-dev@lists.infradead.org
 help / color / mirror / Atom feed
From: "Michael Büsch" <m@bues.ch>
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH][WAS:bcmai,axi] bcma: add Broadcom specific AMBA bus driver
Date: Sun, 08 May 2011 03:44:41 +0200	[thread overview]
Message-ID: <1304819081.21680.6.camel@maggie> (raw)
In-Reply-To: <1304796956.13983.65.camel@dev.znau.edu.ua>

On Sat, 2011-05-07 at 22:35 +0300, George Kashperko wrote: 
> dbg_bcma_device_name
> {
> #ifdef DEBUG
> 		case/switch/if/else stuff
> #endif
> 		return NULL;
> }
> But I don't see here much sense to hardcode names other than those of
> buscommons/buscores for debugging purposes.

Would you please read and understand the code before discussing this?
That would help the discussion on the technical side.

Those names are hardcoded by definition. And just like 14e4 is the PCI
ID for Broadcom devices, 800 is the AXI ID for Broadcom Chipcommon.

And building an #ifdef mess around this stuff is not better than having
a few bytes of _helpful_ information messages.
You are absolutely right that those messages only help 1% of the people.
Just as _any_ other kernel message.

-- 
Greetings Michael.

  parent reply	other threads:[~2011-05-08  1:44 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-08 17:41 [PATCH][WAS:bcmai,axi] bcma: add Broadcom specific AMBA bus driver Rafał Miłecki
     [not found] ` <BANLkTi=epFN2EZBj9n8pac6h7F4RWmyk+Q@mail.gmail.com>
2011-05-05 23:01   ` [PATCH][WAS:bcmai, axi] " Rafał Miłecki
     [not found] ` <201105061605.31625.arnd@arndb.de>
2011-05-06 14:50   ` Rafał Miłecki
2011-05-07 13:34     ` Rafał Miłecki
2011-05-07 13:55       ` [PATCH][WAS:bcmai,axi] " Michael Büsch
     [not found]         ` <4DC57383.3050903@broadcom.com>
2011-05-07 16:49           ` [PATCH][WAS:bcmai, axi] " Rafał Miłecki
     [not found]             ` <4DC57B81.6030705@broadcom.com>
2011-05-07 17:20               ` Rafał Miłecki
     [not found]       ` <1304790665.13983.10.camel@dev.znau.edu.ua>
2011-05-07 18:05         ` Rafał Miłecki
     [not found]           ` <1304792795.13983.28.camel@dev.znau.edu.ua>
2011-05-07 18:48             ` Rafał Miłecki
     [not found]               ` <1304794931.13983.44.camel@dev.znau.edu.ua>
2011-05-07 19:21                 ` Rafał Miłecki
     [not found]                   ` <1304796956.13983.65.camel@dev.znau.edu.ua>
2011-05-08  1:44                     ` Michael Büsch [this message]
     [not found]               ` <20110508101609.GF27807@n2100.arm.linux.org.uk>
2011-05-08 10:37                 ` Rafał Miłecki
     [not found]       ` <201105081706.12449.arnd@arndb.de>
2011-05-08 15:25         ` Rafał Miłecki
     [not found]     ` <201105081647.22091.arnd@arndb.de>
2011-05-08 14:59       ` Rafał Miłecki
     [not found]         ` <201105081759.03032.arnd@arndb.de>
2011-05-09 14:33           ` Rafał Miłecki
     [not found]             ` <20110509153728.GA29762@kroah.com>
2011-05-09 15:48               ` Rafał Miłecki
2011-05-07 16:13 ` Hauke Mehrtens
2011-05-07 16:23   ` Rafał Miłecki
2011-05-07 16:32     ` Hauke Mehrtens
2011-05-07 16:51       ` Rafał Miłecki
2011-05-07 17:24         ` Hauke Mehrtens
2011-05-07 17:35           ` Rafał Miłecki
     [not found]           ` <20110507224223.GA2537@broadcom.com>
2011-05-07 23:17             ` Hauke Mehrtens
2011-05-08 12:48 ` Hauke Mehrtens
2011-05-08 12:55   ` Rafał Miłecki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1304819081.21680.6.camel@maggie \
    --to=m@bues.ch \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox