From: "Michael Büsch" <m@bues.ch>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: linux-wireless@vger.kernel.org, Michael Buesch <mb@bu3sch.de>,
b43-dev <b43-dev@lists.infradead.org>
Subject: ssb: where to reject dangling cores?
Date: Sun, 08 May 2011 03:48:22 +0200 [thread overview]
Message-ID: <1304819302.21680.10.camel@maggie> (raw)
In-Reply-To: <BANLkTimRasoDAbK+tLNFx8zK96Xe1hnHXg@mail.gmail.com>
On Sat, 2011-05-07 at 22:40 +0200, Rafa? Mi?ecki wrote:
> Michael, I can see code for ignoring dangling cores in both: ssb and b43.
>
> In ssb it's quite common, we have:
> 1) we_support_multiple_80211_cores for 80211
> 2) inline checks in ssb_bus_scan for PCI(E)
> 3) inline check in ssb_bus_scan for ETHERNET
>
> However there is also check in b43 at the beginning of b43_one_core_attach:
> if (!pdev ||
> ((pdev->device != 0x4321) &&
> (pdev->device != 0x4313) && (pdev->device != 0x431A))) {
> b43dbg(wl, "Ignoring unconnected 802.11 core\n");
> return -ENODEV;
> }
>
> Should I move this check into ssb?
Well, I'm not sure. _Neither_ place looks fine. It's a dirty workaround
for broken hardware.
If you really want to touch this mess, then yes. Move it into ssb.
--
Greetings Michael.
prev parent reply other threads:[~2011-05-08 1:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-07 20:40 ssb: where to reject dangling cores? Rafał Miłecki
2011-05-08 1:48 ` Michael Büsch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1304819302.21680.10.camel@maggie \
--to=m@bues.ch \
--cc=b43-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mb@bu3sch.de \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).