* ssb: where to reject dangling cores?
@ 2011-05-07 20:40 Rafał Miłecki
2011-05-08 1:48 ` Michael Büsch
0 siblings, 1 reply; 2+ messages in thread
From: Rafał Miłecki @ 2011-05-07 20:40 UTC (permalink / raw)
To: linux-wireless, Michael Buesch; +Cc: b43-dev
Michael, I can see code for ignoring dangling cores in both: ssb and b43.
In ssb it's quite common, we have:
1) we_support_multiple_80211_cores for 80211
2) inline checks in ssb_bus_scan for PCI(E)
3) inline check in ssb_bus_scan for ETHERNET
However there is also check in b43 at the beginning of b43_one_core_attach:
if (!pdev ||
((pdev->device != 0x4321) &&
(pdev->device != 0x4313) && (pdev->device != 0x431A))) {
b43dbg(wl, "Ignoring unconnected 802.11 core\n");
return -ENODEV;
}
Should I move this check into ssb?
--
Rafa?
^ permalink raw reply [flat|nested] 2+ messages in thread* ssb: where to reject dangling cores?
2011-05-07 20:40 ssb: where to reject dangling cores? Rafał Miłecki
@ 2011-05-08 1:48 ` Michael Büsch
0 siblings, 0 replies; 2+ messages in thread
From: Michael Büsch @ 2011-05-08 1:48 UTC (permalink / raw)
To: Rafał Miłecki; +Cc: linux-wireless, Michael Buesch, b43-dev
On Sat, 2011-05-07 at 22:40 +0200, Rafa? Mi?ecki wrote:
> Michael, I can see code for ignoring dangling cores in both: ssb and b43.
>
> In ssb it's quite common, we have:
> 1) we_support_multiple_80211_cores for 80211
> 2) inline checks in ssb_bus_scan for PCI(E)
> 3) inline check in ssb_bus_scan for ETHERNET
>
> However there is also check in b43 at the beginning of b43_one_core_attach:
> if (!pdev ||
> ((pdev->device != 0x4321) &&
> (pdev->device != 0x4313) && (pdev->device != 0x431A))) {
> b43dbg(wl, "Ignoring unconnected 802.11 core\n");
> return -ENODEV;
> }
>
> Should I move this check into ssb?
Well, I'm not sure. _Neither_ place looks fine. It's a dirty workaround
for broken hardware.
If you really want to touch this mess, then yes. Move it into ssb.
--
Greetings Michael.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-05-08 1:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-07 20:40 ssb: where to reject dangling cores? Rafał Miłecki
2011-05-08 1:48 ` Michael Büsch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).