b43-dev.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: "Rafał Miłecki" <zajec5@gmail.com>
To: linux-wireless@vger.kernel.org,
	"John W. Linville" <linville@tuxdriver.com>
Cc: b43-dev@lists.infradead.org, "Pavel Roskin" <proski@gnu.org>,
	"Rafał Miłecki" <zajec5@gmail.com>
Subject: [PATCH 0/3] b43 & bcma: DMA special (translation) bits
Date: Wed, 20 Jul 2011 00:12:19 +0200	[thread overview]
Message-ID: <1311113542-2540-1-git-send-email-zajec5@gmail.com> (raw)

Thanks to Pavel's comments I digged into translation bits and found out
the hackish way we currently use to handle 32-bit and 64-bit DMA.

I've replaced out bit shifting hacks with just a one, documented in the
comment. This workaround ideally should be just fixed, but I'm not going
to blidly change the current behaviour of ssb_dma_translation without
testing that with b43legacy and b44. As I don't have such a hardware,
we will need to find some testers.

In any case, the way we changed the code should be correct. When ssb
function will be fixed, b43 will only require deletion of 2 code lines.

I've tested this code for regressions on my following cards:
1) 14e4:432b (64-bit DMA)
2) 14e4:4315 (64-bit DMA)
3) 14e4:4312 (32-bit DMA)
Transmission is still possible on all of them, no errors were noticed.


Pavel: sorry for CC-ing you with my previous serie. Fortunately this
lead to the much nicer solution, thanks for your help.
I let myself yo CC you once more, as this patch serie tries to fix
issues you pointed to me.

Rafa? Mi?ecki (3):
  b43: replace DMA translation workarounds with just a one, commented
  bcma: inform drivers about translation bits needed for the core
  b43: bcma: get DMA translation bits

 drivers/bcma/core.c            |   16 ++++++++++++++++
 drivers/net/wireless/b43/dma.c |   17 ++++++++++++++---
 drivers/net/wireless/b43/dma.h |    4 ++++
 include/linux/bcma/bcma.h      |    5 +++++
 4 files changed, 39 insertions(+), 3 deletions(-)

-- 
1.7.3.4

             reply	other threads:[~2011-07-19 22:12 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-19 22:12 Rafał Miłecki [this message]
2011-07-19 22:12 ` [PATCH 1/3] b43: replace DMA translation workarounds with just a one, commented Rafał Miłecki
2011-07-19 22:53   ` Larry Finger
2011-07-19 23:15   ` Michael Büsch
2011-07-20  6:16     ` Rafał Miłecki
2011-07-20  8:30       ` Larry Finger
2011-07-20  8:55       ` Michael Büsch
2011-07-20 11:10         ` Rafał Miłecki
2011-07-20 15:35           ` Michael Büsch
     [not found]             ` <4E28422C.60209@gnu.org>
2011-07-21 15:33               ` Rafał Miłecki
2011-07-21 19:34                 ` Michael Büsch
2011-07-21 21:22                   ` Michael Büsch
2011-07-21 21:31                     ` Rafał Miłecki
2011-07-21 21:40                       ` Michael Büsch
2011-07-21 21:49                         ` Larry Finger
     [not found]                   ` <4E2A7B59.80106@gnu.org>
2011-07-23  8:21                     ` Michael Büsch
2011-07-19 22:12 ` [PATCH 2/3] bcma: inform drivers about translation bits needed for the core Rafał Miłecki
2011-07-19 22:12 ` [PATCH 3/3] b43: bcma: get DMA translation bits Rafał Miłecki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1311113542-2540-1-git-send-email-zajec5@gmail.com \
    --to=zajec5@gmail.com \
    --cc=b43-dev@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=proski@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).