From: "Rafał Miłecki" <zajec5@gmail.com>
To: linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>
Cc: b43-dev@lists.infradead.org, "Pavel Roskin" <proski@gnu.org>,
"Rafał Miłecki" <zajec5@gmail.com>
Subject: [PATCH 1/3] b43: replace DMA translation workarounds with just a one, commented
Date: Wed, 20 Jul 2011 00:12:20 +0200 [thread overview]
Message-ID: <1311113542-2540-2-git-send-email-zajec5@gmail.com> (raw)
In-Reply-To: <1311113542-2540-1-git-send-email-zajec5@gmail.com>
Routing bits are always placed in 0xC0000000, there is no any special
bit shifting for 64-bit DMA. We just workaround wrong value (passed by
ssb) in this way. Replace that with just a one workaround and comment
it. Real fix for this requires testing with all ssb drivers.
Signed-off-by: Rafa? Mi?ecki <zajec5@gmail.com>
---
drivers/net/wireless/b43/dma.c | 12 +++++++++---
1 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/b43/dma.c b/drivers/net/wireless/b43/dma.c
index ce572ae..530a153 100644
--- a/drivers/net/wireless/b43/dma.c
+++ b/drivers/net/wireless/b43/dma.c
@@ -174,7 +174,7 @@ static void op64_fill_descriptor(struct b43_dmaring *ring,
addrhi = (((u64) dmaaddr >> 32) & ~SSB_DMA_TRANSLATION_MASK);
addrext = (((u64) dmaaddr >> 32) & SSB_DMA_TRANSLATION_MASK)
>> SSB_DMA_TRANSLATION_SHIFT;
- addrhi |= (ring->dev->dma.translation << 1);
+ addrhi |= ring->dev->dma.translation;
if (slot == ring->nr_slots - 1)
ctl0 |= B43_DMA64_DCTL0_DTABLEEND;
if (start)
@@ -675,7 +675,7 @@ static int dmacontroller_setup(struct b43_dmaring *ring)
b43_dma_write(ring, B43_DMA64_TXRINGHI,
((ringbase >> 32) &
~SSB_DMA_TRANSLATION_MASK)
- | (trans << 1));
+ | trans);
} else {
u32 ringbase = (u32) (ring->dmabase);
@@ -708,7 +708,7 @@ static int dmacontroller_setup(struct b43_dmaring *ring)
b43_dma_write(ring, B43_DMA64_RXRINGHI,
((ringbase >> 32) &
~SSB_DMA_TRANSLATION_MASK)
- | (trans << 1));
+ | trans);
b43_dma_write(ring, B43_DMA64_RXINDEX, ring->nr_slots *
sizeof(struct b43_dmadesc64));
} else {
@@ -1060,6 +1060,12 @@ int b43_dma_init(struct b43_wldev *dev)
#ifdef CONFIG_B43_SSB
case B43_BUS_SSB:
dma->translation = ssb_dma_translation(dev->dev->sdev);
+ /* ssb does not handle 64-bit DMA case, where Client Mode
+ * Translation is set with value 0x2 instead of 0x1. This should
+ * be fixed on ssb side, but requires testing with b43,
+ * b43legacy and b44. */
+ if (b43_read32(dev, SSB_TMSHIGH) & SSB_TMSHIGH_DMA64)
+ dma->translation <<= 1;
break;
#endif
}
--
1.7.3.4
next prev parent reply other threads:[~2011-07-19 22:12 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-19 22:12 [PATCH 0/3] b43 & bcma: DMA special (translation) bits Rafał Miłecki
2011-07-19 22:12 ` Rafał Miłecki [this message]
2011-07-19 22:53 ` [PATCH 1/3] b43: replace DMA translation workarounds with just a one, commented Larry Finger
2011-07-19 23:15 ` Michael Büsch
2011-07-20 6:16 ` Rafał Miłecki
2011-07-20 8:30 ` Larry Finger
2011-07-20 8:55 ` Michael Büsch
2011-07-20 11:10 ` Rafał Miłecki
2011-07-20 15:35 ` Michael Büsch
[not found] ` <4E28422C.60209@gnu.org>
2011-07-21 15:33 ` Rafał Miłecki
2011-07-21 19:34 ` Michael Büsch
2011-07-21 21:22 ` Michael Büsch
2011-07-21 21:31 ` Rafał Miłecki
2011-07-21 21:40 ` Michael Büsch
2011-07-21 21:49 ` Larry Finger
[not found] ` <4E2A7B59.80106@gnu.org>
2011-07-23 8:21 ` Michael Büsch
2011-07-19 22:12 ` [PATCH 2/3] bcma: inform drivers about translation bits needed for the core Rafał Miłecki
2011-07-19 22:12 ` [PATCH 3/3] b43: bcma: get DMA translation bits Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1311113542-2540-2-git-send-email-zajec5@gmail.com \
--to=zajec5@gmail.com \
--cc=b43-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=proski@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).