From: Johannes Berg <johannes@sipsolutions.net>
To: "Michael Büsch" <m@bues.ch>
Cc: "Rafał Miłecki" <zajec5@gmail.com>,
linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
b43-dev@lists.infradead.org
Subject: [PATCH 1/2] ssb: fix DMA translation for some specific boards
Date: Wed, 10 Aug 2011 19:27:03 +0200 [thread overview]
Message-ID: <1312997223.4325.24.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <20110810184406.6cad6d17@milhouse> (sfid-20110810_184423_775264_26C1F383)
On Wed, 2011-08-10 at 18:44 +0200, Michael B?sch wrote:
> > >> + if (dev->id.coreid == SSB_DEV_80211)
> > >> + return (chip_id == 0x4322 || chip_id == 43221 ||
> > >> + chip_id == 43231 || chip_id == 43222);
> > >> + return 0;
> > >> +}
> > >
> > > ACK, apart from this coding style violation (missing curly braces).
> >
> > From kernel CodingStyle:
> > > Do not unnecessarily use braces where a single statement will do.
> > >
> > > if (condition)
> > > action();
> >
> > I guess simple "return" (even when using line break) is still like
> > single statement...
> > Am I wrong?
> >
>
> Last time I checked this only applied to single-line-statements.
> Maybe it changed, though.
Just sidestep the issue and invert the test ;-)
(However, CodingStyle says nothing about single lines, only statements,
and I tend to agree)
johannes
prev parent reply other threads:[~2011-08-10 17:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-10 16:11 [PATCH 1/2] ssb: fix DMA translation for some specific boards Rafał Miłecki
2011-08-10 16:11 ` [PATCH 2/2] b43: fix DMA on some bugged hardware Rafał Miłecki
2011-08-10 16:33 ` Michael Büsch
2011-08-10 16:45 ` Rafał Miłecki
2011-08-10 16:55 ` Michael Büsch
2011-08-10 17:10 ` Rafał Miłecki
2011-08-10 17:15 ` Michael Büsch
2011-08-10 16:40 ` [PATCH 1/2] ssb: fix DMA translation for some specific boards Michael Büsch
2011-08-10 16:42 ` Rafał Miłecki
2011-08-10 16:44 ` Michael Büsch
2011-08-10 17:27 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1312997223.4325.24.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=b43-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=m@bues.ch \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).