From: David Woodhouse <dwmw2@infradead.org>
To: b43-dev@lists.infradead.org
Subject: [PATCH] Fix alignment issues with DMA TX on BCM4331
Date: Sat, 13 Aug 2011 23:07:46 +0100 [thread overview]
Message-ID: <1313273267.16730.3.camel@i7.infradead.org> (raw)
In-Reply-To: <CACna6rxbCnMnxqhKY4ztVdNpxY8p8FzdfShS=8w+mkQ538hiJA@mail.gmail.com>
On Sun, 2011-08-14 at 00:02 +0200, Rafa? Mi?ecki wrote:
> W dniu 13 sierpnia 2011 23:57 u?ytkownik Larry Finger
> <Larry.Finger@lwfinger.net> napisa?:
> >> +
> >> + b43_dma_write(ring, B43_DMA64_TXRINGLO, 0xff0);
> >
> > Should there be a new symbol rather than this magic number?
Probably not. We're testing whether it stores certain bits of the
address, or if the low 12 bits of the register are just hard-coded to
zero. The raw value 0xff0 conveys that as well as any macro name that I
could think of.
> > Tested on BCM4318 on 32-bit system.
>
> The question is if your card supports unaligned (and as result, if you
> tested it at all)
Either way, he confirmed that writing TXCTL last works.
--
dwmw2
next prev parent reply other threads:[~2011-08-13 22:07 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-18 20:14 No DMA RX on some BCM4321, on BCM43224 and BCM43225 Rafał Miłecki
2011-07-18 20:29 ` Larry Finger
2011-07-18 22:30 ` Rafał Miłecki
2011-07-18 23:32 ` Rafał Miłecki
2011-07-19 6:56 ` Rafał Miłecki
2011-07-19 14:46 ` Larry Finger
2011-07-19 15:12 ` Jonas Gorski
2011-07-18 20:41 ` Michael Büsch
2011-07-18 22:39 ` Rafał Miłecki
2011-07-18 22:59 ` Michael Büsch
2011-07-18 23:07 ` Rafał Miłecki
2011-07-18 23:08 ` Michael Büsch
2011-07-18 23:15 ` Rafał Miłecki
2011-07-18 23:24 ` Michael Büsch
2011-07-18 23:29 ` Rafał Miłecki
2011-07-18 23:12 ` Rafał Miłecki
2011-07-19 22:33 ` David Woodhouse
2011-08-12 1:41 ` David Woodhouse
2011-08-12 10:15 ` [PATCH] b43: Mask out unwanted bits of RX slot address David Woodhouse
2011-08-13 19:10 ` Rafał Miłecki
2011-08-13 19:38 ` Michael Büsch
2011-08-13 22:13 ` Rafał Miłecki
2011-08-13 22:56 ` David Woodhouse
2011-08-14 8:18 ` Rafał Miłecki
2011-08-14 8:19 ` David Woodhouse
2011-08-14 9:02 ` Rafał Miłecki
2011-08-14 9:07 ` Rafał Miłecki
2011-08-14 9:24 ` Rafał Miłecki
2011-08-14 9:31 ` Rafał Miłecki
2011-08-14 11:17 ` Rafał Miłecki
2011-08-14 11:22 ` Rafał Miłecki
2011-08-14 11:35 ` David Woodhouse
2011-08-14 15:02 ` Rafał Miłecki
2011-08-14 15:10 ` Michael Büsch
2011-08-14 11:38 ` Rafał Miłecki
2011-08-14 11:52 ` Michael Büsch
2011-08-14 12:06 ` David Woodhouse
2011-08-14 13:43 ` Rafał Miłecki
2011-08-12 10:27 ` [PATCH] Fix alignment issues with DMA TX on BCM4331 David Woodhouse
2011-08-13 19:06 ` Rafał Miłecki
2011-08-13 20:18 ` David Woodhouse
2011-08-13 20:22 ` Rafał Miłecki
2011-08-13 20:36 ` David Woodhouse
2011-08-14 8:09 ` Rafał Miłecki
2011-08-13 21:57 ` Larry Finger
2011-08-13 22:02 ` Rafał Miłecki
2011-08-13 22:07 ` David Woodhouse [this message]
2011-08-13 22:12 ` Rafał Miłecki
2011-08-13 22:17 ` David Woodhouse
2011-08-14 7:10 ` Rafał Miłecki
2011-08-14 7:35 ` Rafał Miłecki
2011-08-14 8:04 ` David Woodhouse
2011-08-14 8:14 ` Rafał Miłecki
2011-08-13 22:14 ` Larry Finger
2011-08-13 22:17 ` David Woodhouse
2011-08-13 22:29 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1313273267.16730.3.camel@i7.infradead.org \
--to=dwmw2@infradead.org \
--cc=b43-dev@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).