From: Johannes Berg <johannes@sipsolutions.net>
To: "Michael Büsch" <m@bues.ch>
Cc: "Rafał Miłecki" <zajec5@gmail.com>,
linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
"David Woodhouse" <dwmw2@infradead.org>,
b43-dev@lists.infradead.org
Subject: [PATCH 3.2 REQUEST] b43: HT-PHY: report signal to mac80211
Date: Mon, 17 Oct 2011 16:36:59 +0200 [thread overview]
Message-ID: <1318862219.3960.11.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <20111017162727.388624fc@milhouse> (sfid-20111017_162736_674563_4740EF3F)
On Mon, 2011-10-17 at 16:27 +0200, Michael B?sch wrote:
> On Sun, 16 Oct 2011 23:30:49 +0200
> Rafa? Mi?ecki <zajec5@gmail.com> wrote:
> > + case B43_PHYTYPE_HT:
> > + /* TODO: is max the right choice? */
> > + status.signal = max(
> > + (__s8) max(rxhdr->phy_ht_power0, rxhdr->phy_ht_power1),
>
> Hm, why is this cast needed? Does it throw a warning?
The cast should probably be a max_t() instead.
johannes
prev parent reply other threads:[~2011-10-17 14:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-16 21:30 [PATCH 3.2 REQUEST] b43: HT-PHY: report signal to mac80211 Rafał Miłecki
2011-10-17 14:27 ` Michael Büsch
2011-10-17 14:35 ` Rafał Miłecki
2011-10-17 14:36 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1318862219.3960.11.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=b43-dev@lists.infradead.org \
--cc=dwmw2@infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=m@bues.ch \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox