From: David Woodhouse <dwmw2@infradead.org>
To: "Michael Büsch" <mb@bu3sch.de>
Cc: John Linville <linville@tuxdriver.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
b43-dev <b43-dev@lists.infradead.org>,
Larry Finger <Larry.Finger@lwfinger.net>
Subject: [PATCH] ssb: Ignore dangling ethernet cores on wireless devices
Date: Wed, 09 Nov 2011 11:14:57 +0000 [thread overview]
Message-ID: <1320837297.1926.6.camel@shinybook.infradead.org> (raw)
In-Reply-To: <1294426085.18385.8.camel@maggie>
On Fri, 2011-01-07 at 19:48 +0100, Michael B?sch wrote:
>
> + case SSB_DEV_ETHERNET:
> + if (bus->bustype == SSB_BUSTYPE_PCI) {
> + if (bus->host_pci->vendor == PCI_VENDOR_ID_BROADCOM &&
> + (bus->host_pci->device & 0xFF00) == 0x4300) {
> + /* This is a dangling ethernet core on a
> + * wireless device. Ignore it. */
> + continue;
> + }
> + }
> + break;
Do you also need to check for (bus->host_pci->device / 1000) == 43?
Or do the chips with 5-digit 'decimal' IDs not have the Ethernet cores?
Would it be better to invert the test and check for != 0x4400?
--
dwmw2
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 5818 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/b43-dev/attachments/20111109/c750bf6b/attachment.bin>
next prev parent reply other threads:[~2011-11-09 11:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-07 18:48 [PATCH] ssb: Ignore dangling ethernet cores on wireless devices Michael Büsch
2011-11-09 11:14 ` David Woodhouse [this message]
2011-11-09 11:50 ` Gábor Stefanik
2011-11-09 11:51 ` Gábor Stefanik
2011-11-09 12:16 ` Jonas Gorski
2011-11-09 13:53 ` Larry Finger
2011-11-09 15:46 ` Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1320837297.1926.6.camel@shinybook.infradead.org \
--to=dwmw2@infradead.org \
--cc=Larry.Finger@lwfinger.net \
--cc=b43-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mb@bu3sch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).