b43-dev.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: "Rafał Miłecki" <zajec5@gmail.com>
To: linux-wireless@vger.kernel.org,
	"John W. Linville" <linville@tuxdriver.com>
Cc: b43-dev@lists.infradead.org, "Rafał Miłecki" <zajec5@gmail.com>
Subject: [PATCH 0/8] b43: reoder functions in phy_n.c
Date: Sat, 17 Dec 2011 13:57:19 +0100	[thread overview]
Message-ID: <1324126647-22425-1-git-send-email-zajec5@gmail.com> (raw)

[APPLYING] This patchset is based on top of wireless-next with:
b43: mark some vars __maybe_unused in b43_nphy_pmu_spur_avoid
applied.


As noted on b43-dev, we got really messy in phy_n.c. Functions were
implemented quite randomly, with specs appering during development,
sometimes without knowing real mining of the routies.

That resulted in code hard to read and with some not-so-nice early
declarations.

This patches makes some cleaning with that code. It moves tons of LOCs,
but I think we have to do this finally instead of going deeper and
deeper into that mess.

As Larry suggested, I've made small patches and tried my best to get
them formatted nicely, to have diffs really clean. I've been
compiling b43 after each patch, so there shouldn't be any build
breakage between.

Rafa? Mi?ecki (8):
  b43: N-PHY: reorder functions: put basic ones at beginning
  b43: N-PHY: reorder functions: collect radio ones
  b43: N-PHY: reorder functions: collect samples ones
  b43: N-PHY: reorder functions: collect RSSI selects
  b43: N-PHY: split gain control workarounds
  b43: N-PHY: reorder functions: move RSSI calibration
  b43: N-PHY: reorder functions: move rest of workarounds
  b43: N-PHY: reorder functions: random clenaups

 drivers/net/wireless/b43/phy_n.c | 4575 +++++++++++++++++++-------------------
 1 files changed, 2301 insertions(+), 2274 deletions(-)

-- 
1.7.7

             reply	other threads:[~2011-12-17 12:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-17 12:57 Rafał Miłecki [this message]
2011-12-17 12:57 ` [PATCH 1/8] b43: N-PHY: reorder functions: put basic ones at beginning Rafał Miłecki
2011-12-17 12:57 ` [PATCH 2/8] b43: N-PHY: reorder functions: collect radio ones Rafał Miłecki
2011-12-17 12:57 ` [PATCH 3/8] b43: N-PHY: reorder functions: collect samples ones Rafał Miłecki
2011-12-17 12:57 ` [PATCH 4/8] b43: N-PHY: reorder functions: collect RSSI selects Rafał Miłecki
2011-12-17 12:57 ` [PATCH 5/8] b43: N-PHY: split gain control workarounds Rafał Miłecki
2011-12-17 12:57 ` [PATCH 6/8] b43: N-PHY: reorder functions: move RSSI calibration Rafał Miłecki
2011-12-17 12:57 ` [PATCH 7/8] b43: N-PHY: reorder functions: move rest of workarounds Rafał Miłecki
2011-12-17 12:57 ` [PATCH 8/8] b43: N-PHY: reorder functions: random clenaups Rafał Miłecki
2011-12-17 18:11 ` [PATCH 0/8] b43: reoder functions in phy_n.c Larry Finger
2011-12-17 18:32   ` Rafał Miłecki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1324126647-22425-1-git-send-email-zajec5@gmail.com \
    --to=zajec5@gmail.com \
    --cc=b43-dev@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).