b43-dev.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Andre Heider <a.heider@gmail.com>
Cc: "Larry Finger" <Larry.Finger@lwfinger.net>,
	"Michael Büsch" <m@bues.ch>,
	linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org,
	"Rafał Miłecki" <zajec5@gmail.com>
Subject: chip id 4318 regression: WARN_ON_ONCE(sdata->vif.hw_queue[i] >= n_queues))
Date: Fri, 08 Jun 2012 08:41:29 +0200	[thread overview]
Message-ID: <1339137689.5832.2.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1339136879.5832.1.camel@jlt3.sipsolutions.net> (sfid-20120608_082807_706668_96C17A95)

On Fri, 2012-06-08 at 08:27 +0200, Johannes Berg wrote:
> On Thu, 2012-06-07 at 23:47 +0200, Andre Heider wrote:
> > On Thu, Jun 7, 2012 at 11:21 PM, Larry Finger <Larry.Finger@lwfinger.net> wrote:
> > > On 06/07/2012 03:56 PM, Johannes Berg wrote:
> > >>
> > >> On Thu, 2012-06-07 at 20:36 +0200, Johannes Berg wrote:
> > >>
> > >>> However, it's also possible to actually *use* the new mac80211 feature.
> > >>> That would also help with IEEE80211_TX_CTL_SEND_AFTER_DTIM, you could
> > >>> ask mac80211 to use a separate HW queue for it (for tx_ring_mcast.) This
> > >>> may be quicker.
> > >>
> > >>
> > >> This might do it, I haven't tested it at all:
> > >>
> > >> http://p.sipsolutions.net/3c6b003bb06e5298.txt
> > >
> > >
> > > With that patch, the driver never loads the firmware. I have not yet found
> > > the reason.
> > 
> > Same here.
> 
> It doesn't start any interfaces, right?
> 
> The patch was incomplete -- it has to register all 5 queues not but
> might not use them, please try this:
> http://p.sipsolutions.net/69a78bbb83cd6421.txt

No, this was wrong too, I forgot to correct the condition in
add_interface, this should be right:

http://p.sipsolutions.net/854d460da251f9d6.txt

johannes

  reply	other threads:[~2012-06-08  6:41 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-06 19:10 chip id 4318 regression: WARN_ON_ONCE(sdata->vif.hw_queue[i] >= n_queues)) Andre Heider
2012-06-06 20:35 ` Johannes Berg
2012-06-07  7:10   ` Andre Heider
2012-06-07  7:16     ` Johannes Berg
2012-06-07 15:24       ` Andre Heider
2012-06-07 16:03         ` Michael Büsch
2012-06-07 17:25           ` Larry Finger
2012-06-07 17:30             ` Michael Büsch
2012-06-07 18:29               ` Larry Finger
2012-06-07 18:34               ` Andre Heider
2012-06-07 18:36           ` Johannes Berg
2012-06-07 20:56             ` Johannes Berg
2012-06-07 21:21               ` Larry Finger
2012-06-07 21:47                 ` Andre Heider
2012-06-08  6:27                   ` Johannes Berg
2012-06-08  6:41                     ` Johannes Berg [this message]
2012-06-08 13:49                       ` Andre Heider
2012-06-08 14:52                         ` Johannes Berg
2012-06-08 15:04                           ` Andre Heider
2012-06-08 15:14                             ` Johannes Berg
2012-06-08 15:16                               ` Johannes Berg
2012-06-08 15:25                                 ` Andre Heider
2012-06-08 15:38                                   ` Larry Finger
2012-06-08 15:43                                     ` Johannes Berg
2012-06-08 15:44                                       ` Johannes Berg
2012-06-08 15:48                                         ` Johannes Berg
2012-06-08 15:52                                           ` Johannes Berg
2012-06-08 15:56                                             ` Andre Heider
2012-06-08 15:59                                               ` Johannes Berg
2012-06-08 16:05                                                 ` Andre Heider
2012-06-08 16:08                                                   ` Johannes Berg
2012-06-08 16:16                                                     ` Andre Heider
2012-06-08 16:20                                                       ` Johannes Berg
2012-06-08 16:24                                                         ` Johannes Berg
2012-06-08 16:41                                                       ` Johannes Berg
2012-06-08 16:54                                                         ` Andre Heider
2012-06-08 16:56                                                           ` Johannes Berg
2012-06-08 16:24                                                   ` Larry Finger
2012-06-08 16:28                                                     ` Johannes Berg
2012-06-08 16:33                                                       ` Michael Büsch
2012-06-08 17:43                                                         ` Larry Finger
2012-06-08 17:56                                                           ` Johannes Berg
2012-06-08 18:11                                                             ` Johannes Berg
2012-06-08 18:28                                                               ` Andre Heider
2012-06-08 18:38                                                                 ` Johannes Berg
2012-06-08 18:10                                                           ` Michael Büsch
2012-06-08 18:23                                                             ` Larry Finger
2012-06-08 18:31                                                               ` Michael Büsch
2012-06-08 19:37                                                                 ` Larry Finger
2012-06-08 19:42                                                                   ` Andre Heider
2012-06-08 18:36                                                     ` Johannes Berg
2012-06-08 18:42                                                       ` Johannes Berg
2012-06-08 19:04                                                         ` Johannes Berg
2012-06-13  8:31                                                           ` Johannes Berg
2012-06-13 15:39                                                             ` Andre Heider
2012-06-13 15:46                                                               ` Johannes Berg
2012-06-13 18:42                                                                 ` Michael Büsch
2012-06-14 16:26                                                                   ` Andre Heider
2012-06-14 16:37                                                                     ` Johannes Berg
2012-06-14 17:00                                                                       ` Andre Heider
2012-06-14 17:09                                                                         ` Johannes Berg
2012-06-14 17:17                                                                           ` Johannes Berg
2012-06-14 17:23                                                                             ` Andre Heider
2012-06-14 17:27                                                                               ` Johannes Berg
2012-06-15  2:03                                                                                 ` Larry Finger
2012-06-15  8:17                                                                                   ` Johannes Berg
2012-06-15 17:14                                                                                   ` Andre Heider
2012-06-08 15:38                                   ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1339137689.5832.2.camel@jlt3.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=Larry.Finger@lwfinger.net \
    --cc=a.heider@gmail.com \
    --cc=b43-dev@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=m@bues.ch \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).