From: Johannes Berg <johannes@sipsolutions.net>
To: Thomas Huehn <thomas@net.t-labs.tu-berlin.de>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
ath9k-devel@lists.ath9k.org, ath5k-devel@lists.ath5k.org,
ilw@linux.intel.com, users@rt2x00.serialmonkey.com,
b43-dev@lists.infradead.org, brcm80211-dev-list@broadcom.com,
chunkeey@googlemail.com, buytenh@wantstofly.org, dsd@gentoo.org,
coelho@ti.com
Subject: [PATCH 2/2] mac80211: Remove control.sta from struct ieee80211_tx_info and restructure tx-path
Date: Tue, 17 Jul 2012 11:44:50 +0200 [thread overview]
Message-ID: <1342518290.7427.9.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1342205545-45382-3-git-send-email-thomas@net.t-labs.tu-berlin.de> (sfid-20120713_205245_114771_49FF4AC7)
Ok first of all, please actually compile the tree after your changes. It
doesn't. When it does, please fix
1) line length in the commit log should be < 72 chars
2) indentation in mac80211.h
3) removal of an important comment in mac80211.h that I pointed out in
previous review
> The tx-path of all affected drivers is restructured to respect the chaneged
> layout of struct ieee80211_tx_info. List of modified drivers:
> ath9k
Please also remove the driver list. git can tell you the modified files
very easily.
johannes
next prev parent reply other threads:[~2012-07-17 9:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-13 18:52 mac80211: Restructure ieee80211_tx_info->control to gain free space along tx-path Thomas Huehn
2012-07-13 18:52 ` [PATCH 1/2] mac80211_hwsim: fix possible race condition in usage of info->control.sta & control.vif Thomas Huehn
2012-07-13 18:52 ` [PATCH 2/2] mac80211: Remove control.sta from struct ieee80211_tx_info and restructure tx-path Thomas Huehn
2012-07-14 10:10 ` Arend van Spriel
2012-07-14 11:44 ` [ath9k-devel] " Felix Fietkau
2012-07-14 12:55 ` Arend van Spriel
2012-07-15 4:49 ` Luciano Coelho
2012-07-17 9:44 ` Johannes Berg [this message]
2012-07-17 12:57 ` [ath5k-devel] " Thomas Huehn
2012-07-17 13:03 ` Johannes Berg
2012-07-17 20:33 ` Thomas Huehn
2012-07-18 6:48 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1342518290.7427.9.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ath5k-devel@lists.ath5k.org \
--cc=ath9k-devel@lists.ath9k.org \
--cc=b43-dev@lists.infradead.org \
--cc=brcm80211-dev-list@broadcom.com \
--cc=buytenh@wantstofly.org \
--cc=chunkeey@googlemail.com \
--cc=coelho@ti.com \
--cc=dsd@gentoo.org \
--cc=ilw@linux.intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=thomas@net.t-labs.tu-berlin.de \
--cc=users@rt2x00.serialmonkey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).