From: Johannes Berg <johannes@sipsolutions.net>
To: Thomas Huehn <thomas@net.t-labs.tu-berlin.de>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
ath9k-devel@lists.ath9k.org, ath5k-devel@lists.ath5k.org,
ilw@linux.intel.com, users@rt2x00.serialmonkey.com,
b43-dev@lists.infradead.org, brcm80211-dev-list@broadcom.com,
chunkeey@googlemail.com, buytenh@wantstofly.org, dsd@gentoo.org,
coelho@ti.com, nbd@openwrt.org
Subject: [PATCH v5] mac80211: Remove control.sta from struct ieee80211_tx_info and restructure tx-path
Date: Wed, 25 Jul 2012 11:36:30 +0200 [thread overview]
Message-ID: <1343208990.4463.25.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1343161108-6941-1-git-send-email-thomas@net.t-labs.tu-berlin.de> (sfid-20120724_221843_511093_701FFAF2)
On Tue, 2012-07-24 at 22:18 +0200, Thomas Huehn wrote:
> The pointer control.sta is removed from ieee80211_tx_info to free up
> sufficient memory in SKB_CB on the tx-path to enable new annotations
> per data packet e.g.support of upcoming Transmit Power Control (TPC).
> Now the control.sta pointer is put on the stack where passed as
> function parameter to the .tx equivalent (ieee80211_ops) of each
> affected wireless driver.
> Therefore a new structure ieee80211_tx_control is added to mac80211.h
> which holds the sta structure instead. The tx-path of all affected
> drivers is restructured to respect the chaneges.
>
> Signed-off-by: Thomas Huehn <thomas@net.t-labs.tu-berlin.de>
> Signed-off-by: Alina Friedrichsen <x-alina@gmx.net>
> Signed-off-by: Felix Fietkau <nbd@openwrt.org>
> ---
> restructure this patch to respect logical API evolutions. thx to Johannes Berg
> add missing drivers that are effected as well. thx to Xose Vazquez Perez
> add missing drivers that are effected as well. thx to Johannes Berg
> simplified control pointer passing in tx.c - thx to Johannes Berg
Finally applied, but I dropped these spurious changes:
> @@ -1301,8 +1302,7 @@ static bool __ieee80211_tx(struct ieee80211_local *local,
> break;
> }
>
> - result = ieee80211_tx_frags(local, vif, pubsta, skbs,
> - txpending);
> + result = ieee80211_tx_frags(local, vif, pubsta, skbs, txpending);
>
> ieee80211_tpt_led_trig_tx(local, fc, led_len);
> ieee80211_led_tx(local, 1);
> @@ -1409,8 +1409,8 @@ static bool ieee80211_tx(struct ieee80211_sub_if_data *sdata,
> sdata->vif.hw_queue[skb_get_queue_mapping(skb)];
>
> if (!invoke_tx_handlers(&tx))
> - result = __ieee80211_tx(local, &tx.skbs, led_len,
> - tx.sta, txpending);
> + result = __ieee80211_tx(local, &tx.skbs, led_len, tx.sta,
> + txpending);
> out:
> rcu_read_unlock();
> return result;
johannes
next prev parent reply other threads:[~2012-07-25 9:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-24 20:18 [PATCH v5] mac80211: Remove control.sta from struct ieee80211_tx_info and restructure tx-path Thomas Huehn
2012-07-25 9:36 ` Johannes Berg [this message]
2012-07-25 12:50 ` Johannes Berg
2012-07-25 13:00 ` Thomas Huehn
2012-07-25 19:25 ` Luciano Coelho
2012-07-26 6:24 ` Johannes Berg
2012-07-26 9:27 ` Thomas Huehn
2012-07-26 11:57 ` Johannes Berg
2012-07-26 13:36 ` Thomas Huehn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1343208990.4463.25.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ath5k-devel@lists.ath5k.org \
--cc=ath9k-devel@lists.ath9k.org \
--cc=b43-dev@lists.infradead.org \
--cc=brcm80211-dev-list@broadcom.com \
--cc=buytenh@wantstofly.org \
--cc=chunkeey@googlemail.com \
--cc=coelho@ti.com \
--cc=dsd@gentoo.org \
--cc=ilw@linux.intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=nbd@openwrt.org \
--cc=thomas@net.t-labs.tu-berlin.de \
--cc=users@rt2x00.serialmonkey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox