From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Berg Date: Tue, 17 Dec 2013 09:08:50 +0100 Subject: [RFC PATCH 1/8] mac80211: Move dynamic PS data out of common code In-Reply-To: <1387231260-2849-2-git-send-email-seth.forshee@canonical.com> (sfid-20131216_230107_034586_FFC8C889) References: <1387231260-2849-1-git-send-email-seth.forshee@canonical.com> <1387231260-2849-2-git-send-email-seth.forshee@canonical.com> (sfid-20131216_230107_034586_FFC8C889) Message-ID: <1387267730.4749.2.camel@jlt4.sipsolutions.net> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Seth Forshee Cc: linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org, brcm80211-dev-list@broadcom.com, "John W. Linville" , Stefano Brivio , Arend van Spriel On Mon, 2013-12-16 at 16:00 -0600, Seth Forshee wrote: > +void ieee80211_notify_rx(struct ieee80211_rx_data *rx) > +{ > + switch(rx->sdata->vif.type) { > + case NL80211_IFTYPE_MONITOR: > + ieee80211_mgd_notify_rx(rx); This ... seems wrong. Also, we already have ieee80211_sta_rx_notify() which you want, I think? With this change, do you even still need local->ps_sdata? johannes