From: Luca Coelho <luca@coelho.fi>
To: ZHAO Gang <gamerh2o@gmail.com>
Cc: Stefano Brivio <stefano.brivio@polimi.it>,
b43-dev@lists.infradead.org, linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>
Subject: [PATCH 1/2] b43: fix the wrong assignment of status.freq in b43_rx()
Date: Fri, 17 Jan 2014 08:24:56 +0200 [thread overview]
Message-ID: <1389939896.8062.53.camel@porter.coelho.fi> (raw)
In-Reply-To: <a8aa052ea196de8256dcdc5b3ae81cfa64d3f9ff.1389935084.git.gamerh2o@gmail.com>
On Fri, 2014-01-17 at 13:27 +0800, ZHAO Gang wrote:
> In following patch, replace b43 specific helper function with kernel
> api to reduce code duplication.
>
> Signed-off-by: ZHAO Gang <gamerh2o@gmail.com>
> ---
> drivers/net/wireless/b43/xmit.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/b43/xmit.c b/drivers/net/wireless/b43/xmit.c
> index 4ae63f4..50e5ddb 100644
> --- a/drivers/net/wireless/b43/xmit.c
> +++ b/drivers/net/wireless/b43/xmit.c
> @@ -821,10 +821,10 @@ void b43_rx(struct b43_wldev *dev, struct sk_buff *skb, const void *_rxhdr)
> * channel number in b43. */
> if (chanstat & B43_RX_CHAN_5GHZ) {
> status.band = IEEE80211_BAND_5GHZ;
> - status.freq = b43_freq_to_channel_5ghz(chanid);
> + status.freq = b43_channel_to_freq_5ghz(chanid);
> } else {
> status.band = IEEE80211_BAND_2GHZ;
> - status.freq = b43_freq_to_channel_2ghz(chanid);
> + status.freq = b43_channel_to_freq_2ghz(chanid);
> }
> break;
> default:
Why do you need this patch if you're going to remove these calls in the
next patch anyway?
--
Luca.
next prev parent reply other threads:[~2014-01-17 6:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-17 5:27 [PATCH 1/2] b43: fix the wrong assignment of status.freq in b43_rx() ZHAO Gang
2014-01-17 5:27 ` [PATCH 2/2] b43: use kernel api to replace b43 specific helper function ZHAO Gang
2014-01-17 6:24 ` Luca Coelho [this message]
2014-01-17 7:11 ` [PATCH 1/2] b43: fix the wrong assignment of status.freq in b43_rx() Rafał Miłecki
2014-01-17 8:56 ` Jonas Gorski
2014-01-17 9:01 ` Luca Coelho
2014-01-17 9:19 ` Jonas Gorski
2014-01-17 9:29 ` ZHAO Gang
2014-01-17 9:37 ` Rafał Miłecki
2014-01-17 9:53 ` Luca Coelho
2014-01-17 12:56 ` ZHAO Gang
2014-01-17 14:00 ` ZHAO Gang
2014-01-17 9:11 ` [PATCH v2] b43: use kernel api to replace b43 specific helper function ZHAO Gang
2014-01-17 12:59 ` ZHAO Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1389939896.8062.53.camel@porter.coelho.fi \
--to=luca@coelho.fi \
--cc=b43-dev@lists.infradead.org \
--cc=gamerh2o@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=stefano.brivio@polimi.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox