From: "Rafał Miłecki" <zajec5@gmail.com>
To: linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>
Cc: b43-dev@lists.infradead.org, "Rafał Miłecki" <zajec5@gmail.com>
Subject: [PATCH 9/9] b43: N-PHY: enable forgotten write of hw power adjust table
Date: Sun, 20 Apr 2014 13:05:51 +0200 [thread overview]
Message-ID: <1397991951-13478-10-git-send-email-zajec5@gmail.com> (raw)
In-Reply-To: <1397991951-13478-1-git-send-email-zajec5@gmail.com>
We've implemented table calculation, but forgot to enable writing it in
power setup function.
By the way document table layout.
Signed-off-by: Rafa? Mi?ecki <zajec5@gmail.com>
---
drivers/net/wireless/b43/phy_n.c | 16 ++++++++++++++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/b43/phy_n.c b/drivers/net/wireless/b43/phy_n.c
index 291b38c..482b312 100644
--- a/drivers/net/wireless/b43/phy_n.c
+++ b/drivers/net/wireless/b43/phy_n.c
@@ -3400,6 +3400,20 @@ static void b43_nphy_tx_prepare_adjusted_power_table(struct b43_wldev *dev)
u8 idx, delta;
u8 i, stf_mode;
+ /* Array adj_pwr_tbl corresponds to the hardware table. It consists of
+ * 21 groups, each containing 4 entries.
+ *
+ * First group has entries for CCK modulation.
+ * The rest of groups has 1 entry per modulation (SISO, CDD, STBC, SDM).
+ *
+ * Group 0 is for CCK
+ * Groups 1..4 use BPSK (group per coding rate)
+ * Groups 5..8 use QPSK (group per coding rate)
+ * Groups 9..12 use 16-QAM (group per coding rate)
+ * Groups 13..16 use 64-QAM (group per coding rate)
+ * Groups 17..20 are unknown
+ */
+
for (i = 0; i < 4; i++)
nphy->adj_pwr_tbl[i] = nphy->tx_power_offset[i];
@@ -3598,10 +3612,8 @@ static void b43_nphy_tx_power_ctl_setup(struct b43_wldev *dev)
}
b43_nphy_tx_prepare_adjusted_power_table(dev);
- /*
b43_ntab_write_bulk(dev, B43_NTAB16(26, 64), 84, nphy->adj_pwr_tbl);
b43_ntab_write_bulk(dev, B43_NTAB16(27, 64), 84, nphy->adj_pwr_tbl);
- */
if (nphy->hang_avoid)
b43_nphy_stay_in_carrier_search(dev, false);
--
1.8.4.5
prev parent reply other threads:[~2014-04-20 11:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-20 11:05 [PATCH 0/9][wireless-next] b43: update N-PHY code Rafał Miłecki
2014-04-20 11:05 ` [PATCH 1/9] b43: N-PHY: drop second noise variance table Rafał Miłecki
2014-04-20 11:05 ` [PATCH 2/9] b43: N-PHY: rev3+: complete workarounds Rafał Miłecki
2014-04-20 11:05 ` [PATCH 3/9] b43: N-PHY: random updates and typo fixes all around Rafał Miłecki
2014-04-20 11:05 ` [PATCH 4/9] b43: N-PHY: implement reading support for radio 0x2057 Rafał Miłecki
2014-04-20 11:05 ` [PATCH 5/9] b43: N-PHY: implement RF control INTC for revs 7+ Rafał Miłecki
2014-04-20 11:05 ` [PATCH 6/9] b43: N-PHY: prepare for rev 7+ RSSI calibration Rafał Miłecki
2014-04-20 11:05 ` [PATCH 7/9] b43: N-PHY: add init & calib values for radio 0x2056 rev 11 Rafał Miłecki
2014-04-20 11:05 ` [PATCH 8/9] b43: N-PHY: fix selection of init & calib values Rafał Miłecki
2014-04-20 11:05 ` Rafał Miłecki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1397991951-13478-10-git-send-email-zajec5@gmail.com \
--to=zajec5@gmail.com \
--cc=b43-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).