public inbox for b43-dev@lists.infradead.org
 help / color / mirror / Atom feed
From: Nicholas Krause <xerofoify@gmail.com>
To: stefano.brivio-hl5o88x/ua9eoWH0uzbU5w@public.gmane.org
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	b43-dev-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: [PATCH] drivers:net:wireless: Add mutex locking for function, b43_op_beacon_set_time in main.c
Date: Fri, 28 Nov 2014 17:16:53 -0500	[thread overview]
Message-ID: <1417213013-19758-1-git-send-email-xerofoify@gmail.com> (raw)

Adds needed mutex lockng  of wl->mutex in order to prevent issues with separate threads executing on
the b43_update_templates function call in the function, b43_op_beacon_set_time at the same time.

Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
---
 drivers/net/wireless/b43/main.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/wireless/b43/main.c b/drivers/net/wireless/b43/main.c
index 5d4173e..19ddc72 100644
--- a/drivers/net/wireless/b43/main.c
+++ b/drivers/net/wireless/b43/main.c
@@ -5094,8 +5094,9 @@ static int b43_op_beacon_set_tim(struct ieee80211_hw *hw,
 {
 	struct b43_wl *wl = hw_to_b43_wl(hw);
 
-	/* FIXME: add locking */
+	mutex_lock(&wl->mutex);
 	b43_update_templates(wl);
+	mutex_unlock(&wl->mutex);
 
 	return 0;
 }
-- 
2.1.0

             reply	other threads:[~2014-11-28 22:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-28 22:16 Nicholas Krause [this message]
2014-11-28 22:40 ` [PATCH] drivers:net:wireless: Add mutex locking for function, b43_op_beacon_set_time in main.c Rafał Miłecki
2014-11-28 23:21   ` Michael Büsch
2014-11-29  3:32     ` nick
2014-11-29  8:54       ` Rafał Miłecki
2014-11-29  8:56       ` Michael Büsch
2014-11-29  9:04         ` Rafał Miłecki
2014-11-29 18:09           ` nick
2014-11-29 18:54             ` Larry Finger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1417213013-19758-1-git-send-email-xerofoify@gmail.com \
    --to=xerofoify@gmail.com \
    --cc=b43-dev-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=stefano.brivio-hl5o88x/ua9eoWH0uzbU5w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox