From: Michael Buesch <mb@bu3sch.de>
To: "richardvoigt@gmail.com" <richardvoigt@gmail.com>
Cc: "Rafał Miłecki" <zajec5@gmail.com>,
linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
b43-dev@lists.infradead.org,
"Myhailo Danylenko" <isbear@ukrpost.net>
Subject: [PATCH] b43: N-PHY: fix copy&paste typo
Date: Fri, 2 Apr 2010 08:28:03 +0100 [thread overview]
Message-ID: <201004020928.03438.mb@bu3sch.de> (raw)
In-Reply-To: <m2y2e59e6971004011605oc44de860q87948992252fbac2@mail.gmail.com>
On Friday 02 April 2010 01:05:22 richardvoigt at gmail.com wrote:
> Does anybody else think all the magic numbers make this code hard to understand?
Not at all. These are perfectly valid decimal numbers.
In my country you learn them in first class at school.
Seriously. What should we do?
#define NTAB_OFFSET_THAT_IS_FIFTEEN 15
No!
And btw, I'm pretty sure that broadcom also opencodes lots of these offsets
and values in their code. And that often is a sane thing to do. Creating
hundred thousands of defines that nobody understands is not a sane solution, either.
> 2010/4/1 Rafa? Mi?ecki <zajec5@gmail.com>:
> > Reported-by: Myhailo Danylenko <isbear@ukrpost.net>
> > Signed-off-by: Rafa? Mi?ecki <zajec5@gmail.com>
> > ---
> > drivers/net/wireless/b43/phy_n.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/net/wireless/b43/phy_n.c b/drivers/net/wireless/b43/phy_n.c
> > index 6fd140a..2ae2445 100644
> > --- a/drivers/net/wireless/b43/phy_n.c
> > +++ b/drivers/net/wireless/b43/phy_n.c
> > @@ -2790,7 +2790,7 @@ static int b43_nphy_cal_tx_iq_lo(struct b43_wldev *dev,
> > }
> > b43_ntab_write_bulk(dev, B43_NTAB16(15, 88), 4,
> > buffer);
> > - b43_ntab_write_bulk(dev, B43_NTAB16(15, 101), 2,
> > + b43_ntab_read_bulk(dev, B43_NTAB16(15, 101), 2,
> > buffer);
> > b43_ntab_write_bulk(dev, B43_NTAB16(15, 85), 2,
> > buffer);
> > --
> > 1.6.4.2
> >
> >
> > _______________________________________________
> > b43-dev mailing list
> > b43-dev at lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/b43-dev
> >
>
--
Greetings, Michael.
prev parent reply other threads:[~2010-04-02 7:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-01 21:11 [PATCH] b43: N-PHY: fix copy&paste typo Rafał Miłecki
2010-04-01 23:05 ` richardvoigt at gmail.com
2010-04-01 23:12 ` Larry Finger
2010-04-02 7:28 ` Michael Buesch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201004020928.03438.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=b43-dev@lists.infradead.org \
--cc=isbear@ukrpost.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=richardvoigt@gmail.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).