[PATCH] b43: Clarify logged message after fatal DMA error and switch to PIO mode

[PATCH] b43: Clarify logged message after fatal DMA error and switch to PIO mode

[Larry Finger]

The message following fatal DMA errors fails to indicate properly that the
driver has switched to PIO mode.

Signed-off-by: Larry Finger <Larry.Finger@wfinger.net>
---

Index: wireless-testing/drivers/net/wireless/b43/main.c
===================================================================
--- wireless-testing.orig/drivers/net/wireless/b43/main.c
+++ wireless-testing/drivers/net/wireless/b43/main.c
@@ -1804,7 +1804,7 @@ static void b43_do_interrupt_thread(stru
 			       dma_reason[2], dma_reason[3],
 			       dma_reason[4], dma_reason[5]);
 			b43err(dev->wl, "This device does not support DMA "
-			       "on your system. Please use PIO instead.\n");
+			       "on your system. It will now be switched to PIO.\n");
 			/* Fall back to PIO transfers if we get fatal DMA errors! */
 			dev->use_pio = 1;
 			b43_controller_restart(dev, "DMA error");

[PATCH] b43: Clarify logged message after fatal DMA error and switch to PIO mode

[Michael Büsch]

On 06/19/2010 03:29 PM, Larry Finger wrote:
> The message following fatal DMA errors fails to indicate properly that the
> driver has switched to PIO mode.
>
> Signed-off-by: Larry Finger<Larry.Finger@wfinger.net>
> ---
>
> Index: wireless-testing/drivers/net/wireless/b43/main.c
> ===================================================================
> --- wireless-testing.orig/drivers/net/wireless/b43/main.c
> +++ wireless-testing/drivers/net/wireless/b43/main.c
> @@ -1804,7 +1804,7 @@ static void b43_do_interrupt_thread(stru
>   			       dma_reason[2], dma_reason[3],
>   			       dma_reason[4], dma_reason[5]);
>   			b43err(dev->wl, "This device does not support DMA "
> -			       "on your system. Please use PIO instead.\n");
> +			       "on your system. It will now be switched to PIO.\n");
>   			/* Fall back to PIO transfers if we get fatal DMA errors! */
>   			dev->use_pio = 1;
>   			b43_controller_restart(dev, "DMA error");
>
> _______________________________________________
> b43-dev mailing list
> b43-dev at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/b43-dev
>

Ack.

But what's the current status of the debugging of the PCI-core code 
w.r.t DMA?

-- 
Greetings Michael.

[PATCH] b43: Clarify logged message after fatal DMA error and switch to PIO mode

[Michael Büsch]

On 06/19/2010 03:29 PM, Larry Finger wrote:
> The message following fatal DMA errors fails to indicate properly that the
> driver has switched to PIO mode.
>
> Signed-off-by: Larry Finger<Larry.Finger@wfinger.net>
> ---
>
> Index: wireless-testing/drivers/net/wireless/b43/main.c
> ===================================================================
> --- wireless-testing.orig/drivers/net/wireless/b43/main.c
> +++ wireless-testing/drivers/net/wireless/b43/main.c
> @@ -1804,7 +1804,7 @@ static void b43_do_interrupt_thread(stru
>   			       dma_reason[2], dma_reason[3],
>   			       dma_reason[4], dma_reason[5]);
>   			b43err(dev->wl, "This device does not support DMA "
> -			       "on your system. Please use PIO instead.\n");
> +			       "on your system. It will now be switched to PIO.\n");
>   			/* Fall back to PIO transfers if we get fatal DMA errors! */
>   			dev->use_pio = 1;
>   			b43_controller_restart(dev, "DMA error");
>

Ack.

But what's the current status of the debugging of the PCI-core code 
w.r.t DMA?

-- 
Greetings Michael.

[PATCH] b43: Clarify logged message after fatal DMA error and switch to PIO mode

[Larry Finger]

On 06/19/2010 08:58 AM, Michael B?sch wrote:
> 
> But what's the current status of the debugging of the PCI-core code
> w.r.t DMA?

There has been no progress.

John: Would you be offended if I tried to swap that HP Mini 110 for some
other Netbook that does have the DMA problem? I was thinking of contacting
Linus as I know he has a box with the problem.

Larry

[PATCH] b43: Clarify logged message after fatal DMA error and switch to PIO mode

[Rafał Miłecki]

2010/6/19 Larry Finger <Larry.Finger@lwfinger.net>:
> On 06/19/2010 08:58 AM, Michael B?sch wrote:
>>
>> But what's the current status of the debugging of the PCI-core code
>> w.r.t DMA?
>
> There has been no progress.

What about PCI specs you prepared some time ago? Can we "suspect" them
to be cure for DMA errors?

-- 
Rafa?

[PATCH] b43: Clarify logged message after fatal DMA error and switch to PIO mode

[Larry Finger]

On 06/19/2010 10:35 AM, Rafa? Mi?ecki wrote:
> 2010/6/19 Larry Finger <Larry.Finger@lwfinger.net>:
>> On 06/19/2010 08:58 AM, Michael B?sch wrote:
>>>
>>> But what's the current status of the debugging of the PCI-core code
>>> w.r.t DMA?
>>
>> There has been no progress.
> 
> What about PCI specs you prepared some time ago? Can we "suspect" them
> to be cure for DMA errors?

They might be as they have not been tested.

Larry

[PATCH] b43: Clarify logged message after fatal DMA error and switch to PIO mode

[John W. Linville]

On Sat, Jun 19, 2010 at 09:05:48AM -0500, Larry Finger wrote:
> On 06/19/2010 08:58 AM, Michael B?sch wrote:
> > 
> > But what's the current status of the debugging of the PCI-core code
> > w.r.t DMA?
> 
> There has been no progress.
> 
> John: Would you be offended if I tried to swap that HP Mini 110 for some
> other Netbook that does have the DMA problem? I was thinking of contacting
> Linus as I know he has a box with the problem.

Fine by me. :-)

-- 
John W. Linville		Someday the world will need a hero, and you
linville at tuxdriver.com			might be all we have.  Be ready.