From: John W. Linville <linville@tuxdriver.com>
To: b43-dev@lists.infradead.org
Subject: [PATCH] ssb: Clear RETRY_TIMEOUT in PCI Configuration
Date: Tue, 16 Nov 2010 15:40:25 -0500 [thread overview]
Message-ID: <20101116204024.GD10774@tuxdriver.com> (raw)
In-Reply-To: <1289425953.17777.5.camel@maggie>
On Wed, Nov 10, 2010 at 10:52:33PM +0100, Michael B?sch wrote:
> On Wed, 2010-11-10 at 12:37 -0500, John W. Linville wrote:
> > Does the other patch handle this case (i.e. devices behind SSB->PCI
> > bridge)? If so, can you explain how?
>
> Yes. For embedded it goes:
>
> native-ssb -> pci-core -> pci-bridge module -> wireless ssb
>
> For PCI it goes:
>
> native pci bus -> pci-bridge module -> wireless ssb
>
> So you see that the pci bridge module is the bus glue for all SSB
> based PCI devices. So we do not need the workaround in the pci-core
> driver code. Just in the pci-bridge code (which is
> drivers/ssb/pcihost_wrapper.c)
>
> > It looks to me like the code
> > in ssb_pcihost_register is only called for PCI-attached b43 (or b44)
> > devices.
>
> Yeah. But devices connected to the ssb-pci-core _are_ PCI attached
> devices.
>
> > Or are you saying the RETRY_TIMEOUT change is inappropriate for a
> > device behind an SSB->PCI bridge?
>
> No. But we already handle that, because the glue code
> (pcihost_wrapper.c) is used for both types.
Thanks for the explanation!
--
John W. Linville Someday the world will need a hero, and you
linville at tuxdriver.com might be all we have. Be ready.
prev parent reply other threads:[~2010-11-16 20:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-19 17:55 [PATCH] ssb: Clear RETRY_TIMEOUT in PCI Configuration Larry Finger
2010-10-19 18:02 ` John W. Linville
2010-10-19 18:21 ` Larry Finger
2010-10-19 21:04 ` Michael Büsch
2010-11-09 23:09 ` Rafał Miłecki
2010-11-09 23:13 ` Michael Büsch
2010-11-10 17:37 ` John W. Linville
2010-11-10 21:52 ` Michael Büsch
2010-11-16 20:40 ` John W. Linville [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101116204024.GD10774@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=b43-dev@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).