public inbox for b43-dev@lists.infradead.org
 help / color / mirror / Atom feed
From: Michael Gerdau <mgd@qata.de>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: linux-wireless@vger.kernel.org,
	"John W. Linville" <linville@tuxdriver.com>,
	b43-dev@lists.infradead.org
Subject: [PATCH] ssb: drop BCM4328 hack for SPROM revision
Date: Thu, 18 Nov 2010 01:12:06 +0100	[thread overview]
Message-ID: <201011180112.18813.mgd@qata.de> (raw)
In-Reply-To: <1290019933-9924-1-git-send-email-zajec5@gmail.com>

> This hacks leads to incorrect SPROM parsing for me and reading for
> example MAC as: 00:00:00:54:00:00. Michael G. who introduced this
> confirmed it is not needed anymore.
> 
> Signed-off-by: Rafa? Mi?ecki <zajec5@gmail.com>
> ---
> Michael: I guess I could add your Tested-by. Is that right?

That ist right. I suppose the correct entry would be
Tested-by: Michael Gerdau <mgd@qata.de>

> John: it's 2.6.38 ofc. It should apply cleanly no matter if you applied
> my previous patch for guessing unknown SPROM revision. There is not
> dependence between that 2 patches.
> ---
>  drivers/ssb/pci.c |    4 ----
>  1 files changed, 0 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/ssb/pci.c b/drivers/ssb/pci.c
> index b5343ac..f529663 100644
> --- a/drivers/ssb/pci.c
> +++ b/drivers/ssb/pci.c
> @@ -580,10 +580,6 @@ static int sprom_extract(struct ssb_bus *bus, struct
> ssb_sprom *out, * Always extract r1. */
>  		out->revision = 1;
>  		ssb_dprintk(KERN_DEBUG PFX "SPROM treated as revision %d\n",
> out->revision); -	} else if (bus->chip_id == 0x4321) {
> -		/* the BCM4328 has a chipid == 0x4321 and a rev 4 SPROM */
> -		out->revision = 4;
> -		ssb_dprintk(KERN_DEBUG PFX "SPROM treated as revision %d\n",
> out->revision); }
> 
>  	switch (out->revision) {


-- 
 Michael Gerdau       email: mgd at qata.de
 GPG-keys available on request or at public keyserver
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.infradead.org/pipermail/b43-dev/attachments/20101118/465405ee/attachment.sig>

  reply	other threads:[~2010-11-18  0:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-17 18:52 [PATCH] ssb: drop BCM4328 hack for SPROM revision Rafał Miłecki
2010-11-18  0:12 ` Michael Gerdau [this message]
2010-11-17 23:08   ` Rafał Miłecki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201011180112.18813.mgd@qata.de \
    --to=mgd@qata.de \
    --cc=b43-dev@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox