From: John W. Linville <linville@tuxdriver.com>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org
Subject: [PATCH 2/2] b43: N-PHY: update 2056 radio on channel switch on rev3+
Date: Tue, 21 Dec 2010 17:32:50 -0500 [thread overview]
Message-ID: <20101221223250.GA10046@tuxdriver.com> (raw)
In-Reply-To: <1292956819-21166-2-git-send-email-zajec5@gmail.com>
On Tue, Dec 21, 2010 at 07:40:19PM +0100, Rafa? Mi?ecki wrote:
> Signed-off-by: Rafa? Mi?ecki <zajec5@gmail.com>
> ---
> John: I ignored over 80 chars warnings, as this is very simple code
> (write-by-write, line-by-line) and I believe this can improve readibility.
Not if you are looking at it with line breaks...
Do you really object to breaking a function call at its third
parameter?
John
--
John W. Linville Someday the world will need a hero, and you
linville at tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2010-12-21 22:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-21 18:40 [PATCH 1/2] b43: N-PHY: use correct channel tables for rev4+ Rafał Miłecki
2010-12-21 18:40 ` [PATCH 2/2] b43: N-PHY: update 2056 radio on channel switch on rev3+ Rafał Miłecki
2010-12-21 22:32 ` John W. Linville [this message]
[not found] ` <1292972268-26327-1-git-send-email-zajec5@gmail.com>
2010-12-21 22:57 ` [PATCH 2/2 V2] " Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101221223250.GA10046@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=b43-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).