From: John W. Linville <linville@tuxdriver.com>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org
Subject: [PATCH 2/4] bcma: allow setting FAST clockmode for a core
Date: Tue, 19 Jul 2011 17:09:14 -0400 [thread overview]
Message-ID: <20110719210913.GD2477@tuxdriver.com> (raw)
In-Reply-To: <CACna6rwCNyOKN+gHESX6Qt7uKQNuPWBrsyTJ1rWzjXMULV5y6Q@mail.gmail.com>
On Tue, Jul 19, 2011 at 10:54:32PM +0200, Rafa? Mi?ecki wrote:
> W dniu 19 lipca 2011 22:50 u?ytkownik Rafa? Mi?ecki <zajec5@gmail.com> napisa?:
> > W dniu 19 lipca 2011 22:42 u?ytkownik John W. Linville
> > <linville@tuxdriver.com> napisa?:
> >> ?CC [M] ?drivers/bcma/core.o
> >> drivers/bcma/core.c: In function ?bcma_core_set_clockmode?:
> >> drivers/bcma/core.c:65:22: error: ?BCMA_CLKCTLST? undeclared (first use in this function)
> >> drivers/bcma/core.c:65:22: note: each undeclared identifier is reported only once for each function it appears in
> >> drivers/bcma/core.c:65:73: error: ?BCMA_CLKCTLST_FORCEHT? undeclared (first use in this function)
> >> drivers/bcma/core.c:69:8: error: ?BCMA_CLKCTLST_HAVEHT? undeclared (first use in this function)
> >> drivers/bcma/core.c: In function ?bcma_core_pll_ctl?:
> >> drivers/bcma/core.c:89:35: error: ?BCMA_CLKCTLST_EXTRESREQ? undeclared (first use in this function)
> >> drivers/bcma/core.c:90:38: error: ?BCMA_CLKCTLST_EXTRESST? undeclared (first use in this function)
> >> drivers/bcma/core.c:93:22: error: ?BCMA_CLKCTLST? undeclared (first use in this function)
> >> make[2]: *** [drivers/bcma/core.o] Error 1
> >> make[1]: *** [drivers/bcma] Error 2
> >> make: *** [drivers] Error 2
> >
> > I'm sorry, that's quite normal you could lost order&dependency with
> > the amount of patches I've sent.
> >
> > As nobody objected, please apply
> > [RFC][PATCH] bcma: move define of BCMA_CLKCTLST register
> > It should be applied before this one.
>
> Could I do something to avoid such a problems in the future?
>
> Should I put info about dependency in cover-letter? Should I create
> own git tree? Should I slow down with sending patches (doing more of
> them before sending)?
It is always good to indicate dependencies, especially on patches
posted in a different series or when the dependency is on a patch
posted as RFC.
John
--
John W. Linville Someday the world will need a hero, and you
linville at tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2011-07-19 21:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-16 23:06 [PATCH 1/4] bcma: trivial: add helpers for masking/setting Rafał Miłecki
2011-07-16 23:06 ` [PATCH 2/4] bcma: allow setting FAST clockmode for a core Rafał Miłecki
2011-07-19 20:42 ` John W. Linville
2011-07-19 20:50 ` Rafał Miłecki
2011-07-19 20:54 ` Rafał Miłecki
2011-07-19 21:09 ` John W. Linville [this message]
2011-07-16 23:06 ` [PATCH 3/4] bcma: allow enabling PLL Rafał Miłecki
2011-07-16 23:06 ` [PATCH 4/4] b43: bcma: implement full core reset Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110719210913.GD2477@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=b43-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).