From mboxrd@z Thu Jan 1 00:00:00 1970 From: John W. Linville Date: Tue, 19 Jul 2011 17:09:14 -0400 Subject: [PATCH 2/4] bcma: allow setting FAST clockmode for a core In-Reply-To: References: <1310857566-2876-1-git-send-email-zajec5@gmail.com> <1310857566-2876-2-git-send-email-zajec5@gmail.com> <20110719204246.GB2477@tuxdriver.com> Message-ID: <20110719210913.GD2477@tuxdriver.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org On Tue, Jul 19, 2011 at 10:54:32PM +0200, Rafa? Mi?ecki wrote: > W dniu 19 lipca 2011 22:50 u?ytkownik Rafa? Mi?ecki napisa?: > > W dniu 19 lipca 2011 22:42 u?ytkownik John W. Linville > > napisa?: > >> ?CC [M] ?drivers/bcma/core.o > >> drivers/bcma/core.c: In function ?bcma_core_set_clockmode?: > >> drivers/bcma/core.c:65:22: error: ?BCMA_CLKCTLST? undeclared (first use in this function) > >> drivers/bcma/core.c:65:22: note: each undeclared identifier is reported only once for each function it appears in > >> drivers/bcma/core.c:65:73: error: ?BCMA_CLKCTLST_FORCEHT? undeclared (first use in this function) > >> drivers/bcma/core.c:69:8: error: ?BCMA_CLKCTLST_HAVEHT? undeclared (first use in this function) > >> drivers/bcma/core.c: In function ?bcma_core_pll_ctl?: > >> drivers/bcma/core.c:89:35: error: ?BCMA_CLKCTLST_EXTRESREQ? undeclared (first use in this function) > >> drivers/bcma/core.c:90:38: error: ?BCMA_CLKCTLST_EXTRESST? undeclared (first use in this function) > >> drivers/bcma/core.c:93:22: error: ?BCMA_CLKCTLST? undeclared (first use in this function) > >> make[2]: *** [drivers/bcma/core.o] Error 1 > >> make[1]: *** [drivers/bcma] Error 2 > >> make: *** [drivers] Error 2 > > > > I'm sorry, that's quite normal you could lost order&dependency with > > the amount of patches I've sent. > > > > As nobody objected, please apply > > [RFC][PATCH] bcma: move define of BCMA_CLKCTLST register > > It should be applied before this one. > > Could I do something to avoid such a problems in the future? > > Should I put info about dependency in cover-letter? Should I create > own git tree? Should I slow down with sending patches (doing more of > them before sending)? It is always good to indicate dependencies, especially on patches posted in a different series or when the dependency is on a patch posted as RFC. John -- John W. Linville Someday the world will need a hero, and you linville at tuxdriver.com might be all we have. Be ready.