From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael =?UTF-8?B?QsO8c2No?= Date: Thu, 21 Jul 2011 23:22:25 +0200 Subject: [PATCH 1/3] b43: replace DMA translation workarounds with just a one, commented In-Reply-To: <20110721193440.2baeaae3@Nokia-N900> References: <1311113542-2540-1-git-send-email-zajec5@gmail.com> <1311113542-2540-2-git-send-email-zajec5@gmail.com> <20110720011509.504022f8@maggie> <20110720105540.1c9d072c@maggie> <20110720153542.69edd601@Nokia-N900> <4E28422C.60209@gnu.org> <20110721193440.2baeaae3@Nokia-N900> Message-ID: <20110721232225.1b0e1f15@maggie> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: b43-dev@lists.infradead.org On Thu, 21 Jul 2011 19:34:40 +0000 Michael B?sch wrote: > For historical reasons there is unused 64bit dma code in b43legacy. I'm not sure whether it would even work. Probably not. Larry's fixes were most likely not ported over. So I looked closer at the code now. The b43legacy 64bit DMA code certainly is dead, unused and broken code. One could remove it, if someone really cares (I don't). However, there is another issue. b43legacy calls ssb_dma_translation() (also on 30/32bit code) for every descriptor. As our ssb patch adds a SSB register read to ssb_dma_translation(), this adds an unacceptable amount of overhead. This needs to be addressed before merging the ssb patch.