[PATCH 1/3] b43: replace DMA translation workarounds with just a one, commented

["Michael Büsch" <m@bues.ch>]

On Sat, 23 Jul 2011 03:42:17 -0400
Pavel Roskin <proski@gnu.org> wrote:

> On 07/21/2011 03:34 PM, Michael B?sch wrote:
> 
> > For historical reasons there is unused 64bit dma code in b43legacy. I'm not sure whether it would even work. Probably not. Larry's fixes were most likely not ported over.
> 
> I tried cleaning it up and found something more interesting in process:
> 
> b43legacy_dma_write(ring, B43legacy_DMA32_RXINDEX, 200);
> 
> Comparing to b43, that 200 is supposed to be
> 
> ring->nr_slots * sizeof(struct b43_dmadesc32)
> 
> For Rx, ring->nr_slots is 64 (B43legacy_RXRING_SLOTS).
> 
> sizeof(struct b43_dmadesc32) is 8.  That gives 512 or 0x200, not the 
> decimal 200!
> 
> I have no idea what kind of effect it can have of the driver.

It doesn't have a significant effect. However, you may fix it if
you want. The number of TX descriptor slots was also lowered in b43.
b43legacy still has the old value. You may change that, too, if you want.
There may be more fixes that were not ported over. However, none of
these should be significant.

-- 
Greetings, Michael.