From: "Michael Büsch" <m@bues.ch>
To: b43-dev@lists.infradead.org
Subject: [PATCH] b43-asm, b43-dasm: Add 5 new instructions.
Date: Mon, 12 Sep 2011 17:36:23 +0200 [thread overview]
Message-ID: <20110912173623.0f5d8113@milhouse> (raw)
In-Reply-To: <alpine.LFD.2.02.1109121714500.18952@oracolo.ing.unibs.it>
On Mon, 12 Sep 2011 17:23:02 +0200 (CEST)
Francesco Gringoli <francesco.gringoli@ing.unibs.it> wrote:
> On Sep 12, 2011, at 11:15 AM, Michael B?sch wrote:
>
> > switch (bin->opcode) {
> >+ case 0x101:
> >+ stmt->u.insn.name = "mul";
> >+ disasm_std_operand(stmt, 0, 0);
> >+ disasm_std_operand(stmt, 1, 1);
> >+ disasm_std_operand(stmt, 2, 2);
> >+ break;
> >
> >There's some whitespace damage here.
>
> New patch (non-damaged) including changes to b43-asm/test.asm
The patch is still damaged. It contains an extra space at the start of
the context lines.
Also, please make sure the patch can be applied with "git am", which means
that it can be applied in the repository root directory with -p1
> ===================================================================
> --- assembler/main.c 2011-08-21 14:16:33.000000000 +0200
> +++ assembler/main.c.orig 2011-09-12 16:47:26.000000000 +0200
^^^
Need one more directory level here. If in doubt, use "git diff".
> @@ -737,6 +737,9 @@
> unsigned int opcode;
>
> switch (insn->op) {
> + case OP_MUL:
> + do_assemble_insn(ctx, insn, 0x101);
> + break;
> case OP_ADD:
> do_assemble_insn(ctx, insn, 0x1C0);
> break;
^
extra whitespace here
--
Greetings, Michael.
next prev parent reply other threads:[~2011-09-12 15:36 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-12 15:23 [PATCH] b43-asm, b43-dasm: Add 5 new instructions Francesco Gringoli
2011-09-12 15:36 ` Michael Büsch [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-09-12 17:30 francesco.gringoli at ing.unibs.it
2011-09-12 18:02 ` Michael Büsch
2011-09-12 8:50 Francesco Gringoli
2011-09-12 9:12 ` Gábor Stefanik
2011-09-12 9:25 ` Michael Büsch
2011-09-12 10:09 ` francesco.gringoli at ing.unibs.it
2011-09-12 10:35 ` Michael Büsch
2011-09-12 10:58 ` francesco.gringoli at ing.unibs.it
2011-09-12 11:19 ` Michael Büsch
2011-09-12 13:16 ` francesco.gringoli at ing.unibs.it
2011-09-12 13:32 ` Michael Büsch
2011-09-12 9:15 ` Michael Büsch
2011-09-12 9:56 ` francesco.gringoli at ing.unibs.it
2011-09-12 10:02 ` Michael Büsch
2011-09-12 11:35 ` Michael Büsch
2011-09-12 13:49 ` francesco.gringoli at ing.unibs.it
2011-09-12 14:04 ` francesco.gringoli at ing.unibs.it
2011-09-12 14:13 ` Michael Büsch
2011-09-12 14:31 ` Michael Büsch
2011-09-12 14:44 ` francesco.gringoli at ing.unibs.it
2011-09-12 15:07 ` Michael Büsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110912173623.0f5d8113@milhouse \
--to=m@bues.ch \
--cc=b43-dev@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).