* Switching ssb to read 8-bit quantities from SPROM
@ 2011-10-26 22:24 Larry Finger
2011-10-27 4:59 ` Michael Büsch
0 siblings, 1 reply; 2+ messages in thread
From: Larry Finger @ 2011-10-26 22:24 UTC (permalink / raw)
To: Michael Buesch, Rafał Miłecki; +Cc: b43-dev, wireless
I tested the effects of changing ssb to read the SSPROM in 8-bit hunks rather
than as 16-bit words in the manner that was just submitted for brcmsmac.
Although this simplifies the calculation of the crc8, it only reduced the size
of the module by 31 bytes, thus I will not be submitting the patch.
When the library version of the crc8 routine was used rather than the one built
into ssb, the size of the driver was increased by 17 bytes.
Larry
^ permalink raw reply [flat|nested] 2+ messages in thread
* Switching ssb to read 8-bit quantities from SPROM
2011-10-26 22:24 Switching ssb to read 8-bit quantities from SPROM Larry Finger
@ 2011-10-27 4:59 ` Michael Büsch
0 siblings, 0 replies; 2+ messages in thread
From: Michael Büsch @ 2011-10-27 4:59 UTC (permalink / raw)
To: Larry Finger; +Cc: Michael Buesch, Rafał Miłecki, b43-dev, wireless
On Wed, 26 Oct 2011 17:24:46 -0500
Larry Finger <Larry.Finger@lwfinger.net> wrote:
> I tested the effects of changing ssb to read the SSPROM in 8-bit hunks rather
> than as 16-bit words in the manner that was just submitted for brcmsmac.
> Although this simplifies the calculation of the crc8, it only reduced the size
> of the module by 31 bytes, thus I will not be submitting the patch.
>
> When the library version of the crc8 routine was used rather than the one built
> into ssb, the size of the driver was increased by 17 bytes.
Well, if this doesn't cause regressions due to the changed reads, I'm OK
with it (as in I don't really care either way).
But it has to be tested on b44, too.
--
Greetings, Michael.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-10-27 4:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-26 22:24 Switching ssb to read 8-bit quantities from SPROM Larry Finger
2011-10-27 4:59 ` Michael Büsch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).