[PATCH] b43: add default option to avoid duplicating device support with brcmsmac

[PATCH] b43: add default option to avoid duplicating device support with brcmsmac

[Rafał Miłecki]

2012/1/11 John W. Linville <linville@tuxdriver.com>:
> +config B43_BCMA_EXTRA
> + ? ? ? bool "Support for devices also supported by brcmsmac"
> + ? ? ? depends on B43_BCMA
> + ? ? ? default n
> +

Is this really *the* solution? I wonder if we can do whatever you're
trying to do in a better way? To let final users try both drivers
without recompiling kernel?

The description also isn't saying too much. I can't imagine anyone
taking decision advisedly other than "n, as it's the default". On
other hand, what should we put here? The whole comparison of drivers?
Can be hard, but I really think there should be more info.

-- 
Rafa?

[PATCH] b43: add default option to avoid duplicating device support with brcmsmac

[John W. Linville]

On Thu, Jan 12, 2012 at 05:11:50PM +0100, Rafa? Mi?ecki wrote:
> 2012/1/11 John W. Linville <linville@tuxdriver.com>:
> > +config B43_BCMA_EXTRA
> > + ? ? ? bool "Support for devices also supported by brcmsmac"
> > + ? ? ? depends on B43_BCMA
> > + ? ? ? default n
> > +
> 
> Is this really *the* solution? I wonder if we can do whatever you're
> trying to do in a better way? To let final users try both drivers
> without recompiling kernel?

Saying "y" would let users try both drivers.  That is up to the
distros or other kernel builders to choose.

At present, they have no choice but to let the two drivers race to
see who gets loaded first or whatever.  I imagine that some would
prefer to have an option that prevents that.

> The description also isn't saying too much. I can't imagine anyone
> taking decision advisedly other than "n, as it's the default". On
> other hand, what should we put here? The whole comparison of drivers?
> Can be hard, but I really think there should be more info.

More info could be put in a "---help---" section.  The summary line
could be different as well, if you can think of a better way to
describe the issue.  I am open to suggestions.

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville at tuxdriver.com			might be all we have.  Be ready.

[PATCH] b43: add default option to avoid duplicating device support with brcmsmac

[Peter Stuge]

John W. Linville wrote:
> The summary line could be different as well, if you can think of a
> better way to describe the issue.  I am open to suggestions.

I think these terms are clear:

Community b43 driver
Broadcom brcmsmac driver

How to apply them I leave up to you. :)


//Peter

[PATCH] b43: add default option to avoid duplicating device support with brcmsmac

[John W. Linville]

On Fri, Jan 13, 2012 at 02:32:48AM +0100, Peter Stuge wrote:
> John W. Linville wrote:
> > The summary line could be different as well, if you can think of a
> > better way to describe the issue.  I am open to suggestions.
> 
> I think these terms are clear:
> 
> Community b43 driver
> Broadcom brcmsmac driver
> 
> How to apply them I leave up to you. :)

Maybe you think that is clear, but it doesn't do much for me.

I could say "Support for devices already supported by the
Broadcom-supported brcmsmac driver"?

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville at tuxdriver.com			might be all we have.  Be ready.

[PATCH] b43: add default option to avoid duplicating device support with brcmsmac

[John W. Linville]

On Fri, Jan 13, 2012 at 01:07:03PM +1100, Julian Calaby wrote:
> 2012/1/13 Rafa? Mi?ecki <zajec5@gmail.com>:
> > 2012/1/11 John W. Linville <linville@tuxdriver.com>:
> >> +config B43_BCMA_EXTRA
> >> + ? ? ? bool "Support for devices also supported by brcmsmac"
> >> + ? ? ? depends on B43_BCMA
> >> + ? ? ? default n
> >> +
> >
> > Is this really *the* solution? I wonder if we can do whatever you're
> > trying to do in a better way? To let final users try both drivers
> > without recompiling kernel?
> 
> Another issue is that this should arguably be default y if brcmsmac is disabled.

Can you help by suggesting the correct Kconfig magic to implement that?

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville at tuxdriver.com			might be all we have.  Be ready.