b43-dev.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Seth Forshee <seth.forshee@canonical.com>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: Hauke Mehrtens <hauke@hauke-m.de>,
	Arend van Spriel <arend@broadcom.com>,
	Scott Sanbar <scott.sanbar@gmail.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"b43-dev@lists.infradead.org" <b43-dev@lists.infradead.org>
Subject: BCM4331 fails to associate after suspend
Date: Thu, 16 Feb 2012 08:55:58 -0600	[thread overview]
Message-ID: <20120216145558.GB30486@ubuntu-macmini> (raw)
In-Reply-To: <20120207152921.GA8464@ubuntu-macmini>

On Tue, Feb 07, 2012 at 09:29:21AM -0600, Seth Forshee wrote:
> On Tue, Feb 07, 2012 at 08:08:11AM +0100, Rafa? Mi?ecki wrote:
> > W dniu 7 lutego 2012 08:04 u?ytkownik Rafa? Mi?ecki <zajec5@gmail.com> napisa?:
> > > 2012/2/6 Seth Forshee <seth.forshee@canonical.com>:
> > >> On Mon, Feb 06, 2012 at 08:13:11PM +0100, Hauke Mehrtens wrote:
> > >>> According to the Broadcom SDK for SoCs bcma_pcicore_serdes_workaround()
> > >>> should be called when coming out of standby/hibernate.
> > >>> The code wl uses to do the same thing as bcma does is open source. You
> > >>> find it in the GPL package of many Broadcom based Wifi Routers.
> > >>
> > >> Thanks for the suggestion. Unfortunately calling
> > >> bcma_pcicore_serdes_workaround() during resume doesn't help. I'll look
> > >> at the wl code to see if I can learn anything there.
> > >
> > > Can you try
> > >
> > >
> > > diff --git a/drivers/bcma/main.c b/drivers/bcma/main.c
> > > index febbc0a..a097a26 100644
> > > --- a/drivers/bcma/main.c
> > > +++ b/drivers/bcma/main.c
> > > @@ -267,6 +267,13 @@ int bcma_bus_resume(struct bcma_bus *bus)
> > > ? ? ? ? ? ? ? ?bcma_core_chipcommon_init(&bus->drv_cc);
> > > ? ? ? ?}
> > >
> > > + ? ? ? /* Init PCIE core */
> > > + ? ? ? core = bcma_find_core(bus, BCMA_CORE_PCIE);
> > > + ? ? ? if (core) {
> > > + ? ? ? ? ? ? ? bus->drv_pci.setup_done = false;
> > > + ? ? ? ? ? ? ? bcma_core_pci_init(&bus->drv_pci);
> > > + ? ? ? }
> > > +
> > > ? ? ? ?list_for_each_entry(core, &bus->cores, list) {
> > > ? ? ? ? ? ? ? ?struct device_driver *drv = core->dev.driver;
> > > ? ? ? ? ? ? ? ?if (drv) {
> > 
> > If this doesn't work out of box, please check if reloading b43 is
> > enough. AFAIR now you have to reload both: b43 and bcma. I hope this
> > patch will let you avoid reloading at least bcma.
> 
> I tried exactly that yesterday, but it doesn't fix the issue. I just
> checked to see if it allows reloading only b43, and it does not. I still
> have to reload bcma to get the wireless working again.

I've been pounding on this quite a bit in the past week, but I haven't
been able to get anywhere so far. Any relevant workarounds I found in wl
have no effect, and neither does any amount of reinitialization.

I'm still digging into the drivers to see if I can learn anything, but
if anyone has more suggestions I'll happily give them a try.

Seth

      reply	other threads:[~2012-02-16 14:55 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-03 22:28 BCM4331 fails to associate after suspend Seth Forshee
2012-02-03 22:37 ` John Schoenick
2012-02-04 10:44 ` Arend van Spriel
2012-02-04 14:25   ` Seth Forshee
2012-02-06 16:56     ` Rafał Miłecki
2012-02-06 17:37       ` Seth Forshee
2012-02-06 19:13         ` Hauke Mehrtens
2012-02-06 22:34           ` Seth Forshee
2012-02-07  7:04             ` Rafał Miłecki
2012-02-07  7:08               ` Rafał Miłecki
2012-02-07 15:29                 ` Seth Forshee
2012-02-16 14:55                   ` Seth Forshee [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120216145558.GB30486@ubuntu-macmini \
    --to=seth.forshee@canonical.com \
    --cc=arend@broadcom.com \
    --cc=b43-dev@lists.infradead.org \
    --cc=hauke@hauke-m.de \
    --cc=linux-wireless@vger.kernel.org \
    --cc=scott.sanbar@gmail.com \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).