From: Seth Forshee <seth.forshee@canonical.com>
To: Hauke Mehrtens <hauke@hauke-m.de>, Arend van Spriel <arend@broadcom.com>
Cc: "Stefano Brivio" <stefano.brivio@polimi.it>,
"Rafał Miłecki" <zajec5@gmail.com>,
linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org
Subject: [PATCH] b43: ensure ext PA lines are enabled for BCM4331
Date: Thu, 31 May 2012 09:26:52 -0500 [thread overview]
Message-ID: <20120531142652.GA32179@thinkpad-t410> (raw)
In-Reply-To: <4FC77D25.4060100@hauke-m.de>
On Thu, May 31, 2012 at 04:16:05PM +0200, Hauke Mehrtens wrote:
> Hi Seth,
>
> why don't you call this from bcma_pmu_workarounds() in
> drivers/bcma/driver_chipcommon_pmu.c instead of calling this from b43? I
> think it looks better to call some workarounds on chip common from bcma
> and not from b43.
Arend recommended calling it from within b43's start op, but I'm not
sure of the reason. Arend?
Agreed though that if there's no need to run it every time the interface
is started then bcma_pmu_workarounds() would be a nicer place for it.
> According to some Broadcom code this should also be called for chip_id
> 43431 when turning it on and in the sprom code.
I'm having trouble parsing this, specifically the "and in the sprom
code" part. Can you clarify?
Thanks,
Seth
next prev parent reply other threads:[~2012-05-31 14:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-31 13:49 [PATCH] b43: ensure ext PA lines are enabled for BCM4331 Seth Forshee
2012-05-31 14:16 ` Hauke Mehrtens
2012-05-31 14:26 ` Seth Forshee [this message]
2012-05-31 16:23 ` Hauke Mehrtens
2012-05-31 22:06 ` Seth Forshee
2012-05-31 22:58 ` Hauke Mehrtens
2012-05-31 17:43 ` Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120531142652.GA32179@thinkpad-t410 \
--to=seth.forshee@canonical.com \
--cc=arend@broadcom.com \
--cc=b43-dev@lists.infradead.org \
--cc=hauke@hauke-m.de \
--cc=linux-wireless@vger.kernel.org \
--cc=stefano.brivio@polimi.it \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox