From: "Michael Büsch" <m@bues.ch>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
b43-dev@lists.infradead.org
Subject: [PATCH] b43: HT-PHY: make it BCMA-only
Date: Sat, 2 Mar 2013 05:09:00 +0100 [thread overview]
Message-ID: <20130302050900.6e768a3e@milhouse> (raw)
In-Reply-To: <1362186865-20539-1-git-send-email-zajec5@gmail.com>
On Sat, 2 Mar 2013 02:14:25 +0100
Rafa? Mi?ecki <zajec5@gmail.com> wrote:
> HT-PHY was found only on BCM4331 which is a BCMA-based chipset. This is
> reallly unlikely we will ever see HT-PHY on SSB thus make the whole code
> BCMA specific. This will allow us to call various BCMA-specific
> functions directly (without extra checks).
>
> Signed-off-by: Rafa? Mi?ecki <zajec5@gmail.com>
> ---
> drivers/net/wireless/b43/Kconfig | 2 +-
> drivers/net/wireless/b43/phy_ht.c | 5 +++++
> 2 files changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/b43/Kconfig b/drivers/net/wireless/b43/Kconfig
> index 7a28d21..09d315d 100644
> --- a/drivers/net/wireless/b43/Kconfig
> +++ b/drivers/net/wireless/b43/Kconfig
> @@ -131,7 +131,7 @@ config B43_PHY_LP
>
> config B43_PHY_HT
> bool "Support for HT-PHY (high throughput) devices (EXPERIMENTAL)"
> - depends on B43 && EXPERIMENTAL
> + depends on B43 && B43_BCMA && EXPERIMENTAL
Makes sense.
What about removing EXPERIMENTAL? This flag is mostly useless these days.
> ---help---
> Support for the HT-PHY.
>
> diff --git a/drivers/net/wireless/b43/phy_ht.c b/drivers/net/wireless/b43/phy_ht.c
> index 7416c5e..3719a88 100644
> --- a/drivers/net/wireless/b43/phy_ht.c
> +++ b/drivers/net/wireless/b43/phy_ht.c
> @@ -346,6 +346,11 @@ static int b43_phy_ht_op_init(struct b43_wldev *dev)
> u16 tmp;
> u16 clip_state[3];
>
> + if (dev->dev->bus_type != B43_BUS_BCMA) {
> + b43err(dev->wl, "HT-PHY is supported only on BCMA bus!\n");
> + return -EOPNOTSUPP;
> + }
> +
> b43_phy_ht_tables_init(dev);
>
> b43_phy_mask(dev, 0x0be, ~0x2);
--
Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/b43-dev/attachments/20130302/fbfe56cf/attachment.sig>
next prev parent reply other threads:[~2013-03-02 4:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-02 1:14 [PATCH] b43: HT-PHY: make it BCMA-only Rafał Miłecki
2013-03-02 4:09 ` Michael Büsch [this message]
2013-03-02 9:19 ` Rafał Miłecki
2013-03-02 9:26 ` Hauke Mehrtens
2013-03-02 9:45 ` Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130302050900.6e768a3e@milhouse \
--to=m@bues.ch \
--cc=b43-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).